Skip to content

TF-TRT MNIST test with V2 converter - #51471

Merged
copybara-service[bot] merged 1 commit into
tensorflow:masterfrom
tfeher:trt_mnist_test
Oct 4, 2021
Merged

TF-TRT MNIST test with V2 converter#51471
copybara-service[bot] merged 1 commit into
tensorflow:masterfrom
tfeher:trt_mnist_test

Conversation

@tfeher

@tfeher tfeher commented Aug 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR extends the MNIST test to use the V2 converter. We create a saved model, and convert it both with and without dynamic shape mode.

Tagging @bixia1 for review. Tracker #45481

@google-ml-butler google-ml-butler Bot added the size:L CL Change Size: Large label Aug 12, 2021
@google-cla google-cla Bot added the cla: yes label Aug 12, 2021
@tfeher tfeher mentioned this pull request Aug 12, 2021
Closed
@rthadur rthadur self-assigned this Aug 13, 2021
@rthadur
rthadur requested a review from bixia1 August 13, 2021 14:44
@google-ml-butler google-ml-butler Bot added the awaiting review Pull request awaiting review label Aug 13, 2021
@bixia1 bixia1 added the comp:gpu:tensorrt Issues specific to TensorRT label Aug 13, 2021
@gbaned gbaned assigned gbaned and unassigned rthadur Aug 17, 2021
@tfeher

tfeher commented Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

@bixia1 this is ready for review

bixia1
bixia1 reviewed Sep 21, 2021
View reviewed changes
Comment thread tensorflow/python/compiler/tensorrt/test/quantization_mnist_test.py Resolved
Comment thread tensorflow/python/compiler/tensorrt/test/quantization_mnist_test.py Resolved
Comment thread tensorflow/python/compiler/tensorrt/test/quantization_mnist_test.py Resolved
Comment thread tensorflow/python/compiler/tensorrt/test/quantization_mnist_test.py Resolved
@tfeher
tfeher force-pushed the trt_mnist_test branch 2 times, most recently from eb360d2 to beef275 Compare September 22, 2021 21:12
tfeher
tfeher commented Sep 22, 2021
View reviewed changes

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bixia1 for the comments, I have updated the PR.

Comment thread tensorflow/python/compiler/tensorrt/test/quantization_mnist_test.py Resolved
Comment thread tensorflow/python/compiler/tensorrt/test/quantization_mnist_test.py Resolved
Comment thread tensorflow/python/compiler/tensorrt/test/quantization_mnist_test.py Resolved
Comment thread tensorflow/python/compiler/tensorrt/test/quantization_mnist_test.py Resolved
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 22, 2021
@gbaned gbaned removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Sep 23, 2021
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 24, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 24, 2021
@gbaned

gbaned commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

@tfeher Can you please resolve conflicts? Thanks!

@gbaned gbaned removed the ready to pull PR ready for merge process label Sep 29, 2021
@tfeher

tfeher commented Sep 29, 2021

Copy link
Copy Markdown
Contributor Author

@gbaned I have resolved the conflicts.

@gbaned
gbaned requested a review from bixia1 September 30, 2021 13:45
@google-ml-butler google-ml-butler Bot added the awaiting review Pull request awaiting review label Sep 30, 2021
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 30, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 30, 2021
@google-ml-butler google-ml-butler Bot removed the ready to pull PR ready for merge process label Sep 30, 2021
tfeher
tfeher commented Sep 30, 2021
View reviewed changes

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the import line.

@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 30, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 30, 2021
@gbaned gbaned removed the awaiting review Pull request awaiting review label Oct 1, 2021
@copybara-service
copybara-service Bot merged commit f649b2b into tensorflow:master Oct 4, 2021
@google-ml-butler google-ml-butler Bot removed the ready to pull PR ready for merge process label Oct 4, 2021
@tfeher tfeher mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bixia1 bixia1 bixia1 approved these changes
@gbaned gbaned gbaned approved these changes

Assignees

@gbaned gbaned

Labels

cla: yes comp:gpu:tensorrt Issues specific to TensorRT size:L CL Change Size: Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tfeher @gbaned @bixia1 @kokoro-team @rthadur