Skip to content

Add TF-TRT Python integration tests in dynamic shape mode - #51411

Merged
copybara-service[bot] merged 1 commit into
tensorflow:masterfrom
tfeher:trt_python_test_dynamic_shape
Sep 14, 2021
Merged

copybara-service[bot] merged 1 commit into
tensorflow:masterfrom
tfeher:trt_python_test_dynamic_shape

Conversation

@tfeher

@tfeher tfeher commented Aug 10, 2021 •

Copy link
Copy Markdown
Contributor

This PR updates TF-TRT Python unit test to run both implicit batch and dynamic shape tests.

Some of the test have to be adjusted because the conversion rate is different in dynamic shape mode. Comments that explain the difference are added to the tests.

Apart from updating the test, this PR also removes the requirement to run build mode in dynamic shape mode. The necessary changes in trt_engine_op were implemented already in dynamic shape phase 3, but the Python side error message was not removed at that time.

Tagging @bixia1 for review. Tracker #45481

@google-ml-butler google-ml-butler Bot added the size:M CL Change Size: Medium label Aug 10, 2021
@google-cla google-cla Bot added the cla: yes label Aug 10, 2021
@gbaned gbaned self-assigned this Aug 10, 2021
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label Aug 10, 2021
@gbaned
gbaned requested a review from bixia1 August 10, 2021 18:51
@google-ml-butler google-ml-butler Bot added the awaiting review Pull request awaiting review label Aug 10, 2021

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bixia1 for the review, I have addressed the issues.

@tfeher
tfeher force-pushed the trt_python_test_dynamic_shape branch from 11f1729 to 24e43e5 Compare August 11, 2021 11:59
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 11, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 11, 2021
@rthadur rthadur added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Aug 12, 2021
@gbaned gbaned removed the ready to pull PR ready for merge process label Aug 16, 2021
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 16, 2021
@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Aug 16, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Aug 17, 2021
@bixia1

bixia1 commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

I see these test failure
tf_function_test
gpu_int32
gpu_cast_test

@gbaned

gbaned commented Aug 20, 2021

Copy link
Copy Markdown
Contributor

@tfeher Can you please check @bixia1's comments and keep us posted ? Thanks!

@gbaned gbaned added stat:awaiting response Status - Awaiting response from author and removed ready to pull PR ready for merge process labels Aug 20, 2021
@tensorflowbutler tensorflowbutler added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Sep 9, 2021
- Remove requirement to run build mode in dynamic shape mode
- Update tf_trt_integration_ test_base for dynamic shape tests
- Update unary op test for dynamic shape mode
- Rank_two test updated for dynamic shapes
- Fix binary_tensor_weight_broadcast test
- Fix biasadd matmul test
- trt_mode_test fixed
- combined nms expects no conversion in dynamic shape mode
- tf_function_test fixed
- Fix input type when calling build mode in integration tests
@tfeher
tfeher force-pushed the trt_python_test_dynamic_shape branch from 24e43e5 to eb158f0 Compare September 13, 2021 14:01
@tfeher

tfeher commented Sep 13, 2021

Copy link
Copy Markdown
Contributor Author

@bixia1 I have fixed the failing tests. Sorry for the delay.

@google-ml-butler google-ml-butler Bot removed stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author labels Sep 13, 2021
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 13, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 13, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Sep 14, 2021
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 14, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 14, 2021
@copybara-service
copybara-service Bot merged commit 96d0a7c into tensorflow:master Sep 14, 2021
@google-ml-butler google-ml-butler Bot removed the ready to pull PR ready for merge process label Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes comp:gpu:tensorrt Issues specific to TensorRT size:M CL Change Size: Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants