Repository navigation
Add TF-TRT Python integration tests in dynamic shape mode - #51411
Merged
copybara-service[bot] merged 1 commit intoSep 14, 2021
Merged
copybara-service[bot] merged 1 commit into
copybara-service[bot] merged 1 commit into
Conversation
bixia1
reviewed
Aug 10, 2021
tfeher
commented
Aug 11, 2021
tfeher
force-pushed
the
trt_python_test_dynamic_shape
branch
from
August 11, 2021 11:59
11f1729 to
24e43e5
Compare
bixia1
approved these changes
Aug 11, 2021
gbaned
approved these changes
Aug 16, 2021
Contributor
Contributor
- Remove requirement to run build mode in dynamic shape mode - Update tf_trt_integration_ test_base for dynamic shape tests - Update unary op test for dynamic shape mode - Rank_two test updated for dynamic shapes - Fix binary_tensor_weight_broadcast test - Fix biasadd matmul test - trt_mode_test fixed - combined nms expects no conversion in dynamic shape mode - tf_function_test fixed - Fix input type when calling build mode in integration tests
tfeher
force-pushed
the
trt_python_test_dynamic_shape
branch
from
September 13, 2021 14:01
24e43e5 to
eb158f0
Compare
Contributor
Author
|
@bixia1 I have fixed the failing tests. Sorry for the delay. |
bixia1
approved these changes
Sep 13, 2021
gbaned
approved these changes
Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR updates TF-TRT Python unit test to run both implicit batch and dynamic shape tests.
Some of the test have to be adjusted because the conversion rate is different in dynamic shape mode. Comments that explain the difference are added to the tests.
Apart from updating the test, this PR also removes the requirement to run build mode in dynamic shape mode. The necessary changes in trt_engine_op were implemented already in dynamic shape phase 3, but the Python side error message was not removed at that time.
Tagging @bixia1 for review. Tracker #45481