Repository navigation
TF-TRT implement Range and RangeOptimal optimization profile strategies - #48414
Merged
copybara-service[bot] merged 1 commit intoMay 13, 2021
Merged
Conversation
tfeher
force-pushed
the
trt_profile_strategies
branch
from
April 8, 2021 17:54
a64a3d7 to
64432b8
Compare
bixia1
self-requested a review
April 8, 2021 20:19
bixia1
reviewed
Apr 8, 2021
| for (int i = 1; i < collected_shapes.size(); i++) { | ||
| TF_RETURN_IF_ERROR(ShapeProfileBinaryOp( | ||
| min, collected_shapes[i], [](int a, int b) { return std::min(a, b); }, | ||
| &min)); |
Contributor
There was a problem hiding this comment.
Can we replace the lambda with std::min?
Contributor
Author
There was a problem hiding this comment.
Not simply, it is overleaded and the lambda is used to resolve ambiguity. Alternatively, we could cast it to a function pointer if you prefer that solution.
tfeher
force-pushed
the
trt_profile_strategies
branch
2 times, most recently
from
April 8, 2021 22:57
f9c6902 to
7f9faf3
Compare
tfeher
commented
Apr 8, 2021
| for (int i = 1; i < collected_shapes.size(); i++) { | ||
| TF_RETURN_IF_ERROR(ShapeProfileBinaryOp( | ||
| min, collected_shapes[i], [](int a, int b) { return std::min(a, b); }, | ||
| &min)); |
Contributor
Author
There was a problem hiding this comment.
Not simply, it is overleaded and the lambda is used to resolve ambiguity. Alternatively, we could cast it to a function pointer if you prefer that solution.
bixia1
approved these changes
Apr 14, 2021
google-ml-butler
Bot
added
kokoro:force-run
bixia1
requested changes
Apr 15, 2021
Contributor
gbaned
added
stat:awaiting response
Contributor
|
@tfeher Any update on this PR? Please. Thanks! |
tfeher
force-pushed
the
trt_profile_strategies
branch
from
May 3, 2021 19:37
7f9faf3 to
ef46a8d
Compare
tfeher
commented
May 3, 2021
tfeher
left a comment
tfeher
left a comment
Contributor
Author
There was a problem hiding this comment.
Sorry for the delay, I have updated the PR to fix the issue with TRT5 compilation.
gbaned
added
awaiting review
bixia1
approved these changes
May 12, 2021
google-ml-butler
Bot
added
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Range and RangeOptimal optimization profile strategies for TF-TRT dynamic shape mode.
Tagging @bixia1 for review and @DEKHTIARJonathan for visibility.
Tracker: #45481