Repository navigation
TF-TRT SpaceToDepth and DepthToSpace op converters for dynamic shape mode. - #47590
Merged
copybara-service[bot] merged 1 commit intoMar 23, 2021
Merged
copybara-service[bot] merged 1 commit into
copybara-service[bot] merged 1 commit into
Conversation
tfeher
force-pushed
the
trt_depthspaceshuffle_dynamic
branch
from
March 14, 2021 23:49
cdc9d9e to
4749454
Compare
bixia1
self-requested a review
March 18, 2021 21:06
bixia1
reviewed
Mar 18, 2021
tfeher
force-pushed
the
trt_depthspaceshuffle_dynamic
branch
from
March 21, 2021 12:41
4749454 to
026b878
Compare
tfeher
commented
Mar 21, 2021
bixia1
reviewed
Mar 22, 2021
tfeher
force-pushed
the
trt_depthspaceshuffle_dynamic
branch
from
March 22, 2021 22:42
026b878 to
2b283d8
Compare
tfeher
commented
Mar 22, 2021
Contributor
|
Prefer using return values over output parameters: they improve readability, and often provide the same or better performance |
bixia1
approved these changes
Mar 22, 2021
google-ml-butler
Bot
added
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the converter for the SpaceToDepth and DepthToSpace ops to work with explicit batch and dynamic shape mode.
While the explicit batch converter needs only a slight modification to insert the batch dim, the dynamic shape converter has to redefine the same target shape calculation using TRT shape tensor arithmetic.
The unit test are updated to run all three trt modes. The parameters are not modified, just refactored to allow execution in all trt modes.
Tagging @bixia1 for review and @DEKHTIARJonathan for visibility.
Tracker: #45481