Skip to content

TF-TRT Dynamic shape mode test for Softmax op converter - #47039

Merged
copybara-service[bot] merged 1 commit into
tensorflow:masterfrom
tfeher:trt_softmax_dynamic_shape
Mar 16, 2021
Merged

TF-TRT Dynamic shape mode test for Softmax op converter#47039
copybara-service[bot] merged 1 commit into
tensorflow:masterfrom
tfeher:trt_softmax_dynamic_shape

Conversation

@tfeher

@tfeher tfeher commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

This PR adds explicit batch and dynamic shape mode test for the softmax op converter.

Tagging @bixia1 for review and @DEKHTIARJonathan for visibility

Tracker: #45481

@google-ml-butler google-ml-butler Bot added the size:S CL Change Size: Small label Feb 9, 2021
@google-ml-butler
google-ml-butler Bot requested a review from joker-eph February 9, 2021 13:37
@google-cla google-cla Bot added the cla: yes label Feb 9, 2021
@tfeher
tfeher force-pushed the trt_softmax_dynamic_shape branch from 4405908 to dcce845 Compare February 9, 2021 13:40
@gbaned gbaned self-assigned this Feb 9, 2021
bixia1
bixia1 reviewed Feb 9, 2021
View reviewed changes
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
@gbaned

gbaned commented Feb 16, 2021

Copy link
Copy Markdown
Contributor

@tfeher Can you please check @bixia1's comments and keep us posted ? Thanks!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Feb 16, 2021
@tensorflowbutler tensorflowbutler added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Mar 5, 2021
@tensorflowbutler

tensorflowbutler commented Mar 5, 2021

Copy link
Copy Markdown
Member

It has been 15 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

@tfeher

tfeher commented Mar 5, 2021

Copy link
Copy Markdown
Contributor Author

The PR is still valid, will update this in a few days.

@google-ml-butler google-ml-butler Bot removed the stale This label marks the issue/pr stale - to be closed automatically if no activity label Mar 5, 2021
@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Mar 8, 2021
@tfeher
tfeher force-pushed the trt_softmax_dynamic_shape branch from dcce845 to cec6088 Compare March 14, 2021 23:38
tfeher
tfeher commented Mar 14, 2021
View reviewed changes

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bixia1 for the review, I have addressed the issues.

Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 15, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 15, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Mar 16, 2021
@copybara-service
copybara-service Bot merged commit ea99221 into tensorflow:master Mar 16, 2021
@tfeher tfeher mentioned this pull request Mar 16, 2021
Closed
@tfeher
tfeher deleted the trt_softmax_dynamic_shape branch May 16, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bixia1 bixia1 bixia1 approved these changes
@joker-eph joker-eph Awaiting requested review from joker-eph

Assignees

@gbaned gbaned

Labels

cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tfeher @gbaned @tensorflowbutler @bixia1 @kokoro-team