Repository navigation
[TFTRT - Dynamic Shape Phase 3] Add Dynamic Shape Testing for ConvertAddN and DebugString templated for nested numerical vectors - #46675
Merged
copybara-service[bot] merged 1 commit intoFeb 5, 2021
Merged
copybara-service[bot] merged 1 commit into
copybara-service[bot] merged 1 commit into
Conversation
bixia1
reviewed
Jan 26, 2021
smit-hinsu
removed their request for review
January 27, 2021 00:44
Contributor
Author
|
@bixia1 I think I covered all your reviews. Can you please check ;) |
bixia1
reviewed
Jan 28, 2021
Contributor
Author
|
@bixia1 I updated the PR. Can you please elaborate your comment : #46675 (comment) I didn't get what you mean here |
DEKHTIARJonathan
changed the title
bixia1
reviewed
Feb 2, 2021
bixia1
left a comment
bixia1
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Just a typo in the comment and I will approve it after this.
Contributor
Author
|
We are all good this time @bixia1 ;) |
bixia1
approved these changes
Feb 2, 2021
google-ml-butler
Bot
added
kokoro:force-run
rthadur
added
ready to pull
Contributor
Author
|
@bixia1 could you let me know what is the issue with this PR ? That way we can move forward ? |
Contributor
|
It currently stuck at the merge process, likely due to some irrelevant test failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bixia1 @tfeher for review
Feature Tracker: #45481