Skip to content

TF-TRT Test ConvertConcat in dynamic shape mode - #46382

Closed
tfeher wants to merge 1 commit into
tensorflow:masterfrom
tfeher:trt_concat_dynamic
Closed

tfeher wants to merge 1 commit into
tensorflow:masterfrom
tfeher:trt_concat_dynamic

Conversation

@tfeher

@tfeher tfeher commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

This PR adds explicit batch and dynamic shape mode tests to ConvertConcat.

Tagging @bixia1 for review and @DEKHTIARJonathan for visibility.

Tracker: #45481

@google-ml-butler google-ml-butler Bot added the size:L CL Change Size: Large label Jan 12, 2021
@google-ml-butler
google-ml-butler Bot requested a review from joker-eph January 12, 2021 23:08
@google-cla google-cla Bot added the cla: yes label Jan 12, 2021
@bixia1
bixia1 self-requested a review January 12, 2021 23:37
@gbaned gbaned self-assigned this Jan 13, 2021
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label Jan 13, 2021
@tfeher
tfeher force-pushed the trt_concat_dynamic branch from 80c8cca to 40508ef Compare January 13, 2021 11:21

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bixia1 for the review! I have addressed the issues.

@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 13, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 13, 2021
@tfeher
tfeher force-pushed the trt_concat_dynamic branch from 40508ef to c118523 Compare January 14, 2021 17:58
@google-ml-butler google-ml-butler Bot removed the ready to pull PR ready for merge process label Jan 14, 2021

@bixia1 bixia1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to figure out how to trigger the internal merge process.

@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 14, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 14, 2021
copybara-service Bot pushed a commit that referenced this pull request Jan 14, 2021
Imported from GitHub PR #46382

This PR adds explicit batch and dynamic shape mode tests to ConvertConcat.

Tagging @bixia1 for review and @DEKHTIARJonathan for visibility.

Tracker: #45481
Copybara import of the project:

--
40508ef by Tamas Bela Feher <[email protected]>:

TF-TRT Test ConvertConcat in dynamic shape mode

COPYBARA_INTEGRATE_REVIEW=#46382 from tfeher:trt_concat_dynamic 40508ef
PiperOrigin-RevId: 351863997
Change-Id: I65b51b9aaba5301665687a9c730945d25e657676
@rthadur

rthadur commented Jan 14, 2021

Copy link
Copy Markdown
Contributor

Seems auto-merge is not happening but the changes are now committed so we can close this. Thank you for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:L CL Change Size: Large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants