Repository navigation
[TFTRT - Dynamic Shape Phase 3] Add Dynamic Shape Testing for ConvertResize & Various TF2TRT Node Convert Unittest Improvements - #46376
Merged
copybara-service[bot] merged 1 commit intoJan 25, 2021
Merged
copybara-service[bot] merged 1 commit into
copybara-service[bot] merged 1 commit into
Conversation
Contributor
Author
INFO: Elapsed time: 198.196s, Critical Path: 190.09s
INFO: 78 processes: 78 local.
INFO: Build completed successfully, 80 total actions
//tensorflow/compiler/tf2tensorrt:convert_graph_test PASSED in 14.9s
//tensorflow/compiler/tf2tensorrt:convert_graph_test_gpu PASSED in 14.4s
//tensorflow/compiler/tf2tensorrt:convert_nodes_test PASSED in 82.8s
//tensorflow/compiler/tf2tensorrt:convert_nodes_test_gpu PASSED in 82.1s
//tensorflow/compiler/tf2tensorrt:segment_test PASSED in 0.2s
//tensorflow/compiler/tf2tensorrt:segment_test_gpu PASSED in 0.1s
//tensorflow/compiler/tf2tensorrt:tensorrt_test_cc PASSED in 12.7s
//tensorflow/compiler/tf2tensorrt:tensorrt_test_cc_gpu PASSED in 12.8s
//tensorflow/compiler/tf2tensorrt:trt_allocator_test PASSED in 0.1s
//tensorflow/compiler/tf2tensorrt:trt_engine_op_test PASSED in 12.4s
//tensorflow/compiler/tf2tensorrt:trt_engine_op_test_gpu PASSED in 12.4s
//tensorflow/compiler/tf2tensorrt:trt_engine_resource_ops_test PASSED in 12.2s
//tensorflow/compiler/tf2tensorrt:trt_engine_resource_ops_test_gpu PASSED in 12.1s
//tensorflow/compiler/tf2tensorrt:trt_lru_cache_test PASSED in 0.1s
//tensorflow/compiler/tf2tensorrt:trt_shape_optimization_profiles_test PASSED in 12.8s
//tensorflow/compiler/tf2tensorrt:trt_shape_optimization_profiles_test_gpu PASSED in 12.5s
Executed 16 out of 16 tests: 16 tests pass.
INFO: Build completed successfully, 80 total actions
**** |
bixia1
reviewed
Jan 12, 2021
Contributor
Author
|
@bixia1 there seems to be an issue with DynamicShape & |
tfeher
reviewed
Jan 13, 2021
bixia1
reviewed
Jan 20, 2021
Contributor
Author
|
@bixia1 : we are good to go. All the modifications needed requested are merged and the PR has been squashed. |
bixia1
reviewed
Jan 21, 2021
DEKHTIARJonathan
changed the title
Contributor
Author
|
@bixia1 I have applied the changes you requested. I have also updated PR Title and PR Description. If you would prefer smthg else, please give me the exact content you want me to copy/paste. (Or you can also directly edit if allowed by Github). |
bixia1
reviewed
Jan 21, 2021
bixia1
left a comment
bixia1
left a comment
Contributor
There was a problem hiding this comment.
There are two import things in this PR: change to the converter and new test cases. Can we change the PR description to use this:
ConvertResize now requires a static shape for the tensor representing the resized size to workaround the fact that we can't support shape tensors as inputs yet.
Add dynamic shape test cases for ConvertResize.
Contributor
Author
|
@bixia1 I updated as you asked |
bixia1
approved these changes
Jan 22, 2021
google-ml-butler
Bot
added
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bixia1 @tfeher for review
ConvertResize now requires a static shape for the tensor representing the resized size to workaround the fact that we can't support shape tensors as inputs yet.
Add dynamic shape test cases for ConvertResize.
Feature Tracker: #45481