Skip to content

TF-TRT Test ConvertTopK in dynamic shape mode - #46299

Merged
copybara-service[bot] merged 1 commit into
tensorflow:masterfrom
tfeher:trt_topk_dynamic
Jan 14, 2021
Merged

TF-TRT Test ConvertTopK in dynamic shape mode#46299
copybara-service[bot] merged 1 commit into
tensorflow:masterfrom
tfeher:trt_topk_dynamic

Conversation

@tfeher

@tfeher tfeher commented Jan 8, 2021

Copy link
Copy Markdown
Contributor

This PR adds explicit batch and dynamic shape unit tests for TopK op converter.

Additionally the RunValidationAndConversion test routine is extended to handle multiple output tensors.

Tagging @bixia1 for review and @DEKHTIARJonathan for visibility.

Tracker: #45481

@google-ml-butler google-ml-butler Bot added the size:M CL Change Size: Medium label Jan 8, 2021
@google-ml-butler
google-ml-butler Bot requested a review from joker-eph January 8, 2021 21:21
@google-cla google-cla Bot added the cla: yes label Jan 8, 2021
@gbaned gbaned self-assigned this Jan 11, 2021
@gbaned
gbaned requested a review from bixia1 January 11, 2021 04:29
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label Jan 11, 2021
bixia1
bixia1 reviewed Jan 11, 2021
View reviewed changes
Comment thread tensorflow/compiler/tf2tensorrt/utils/trt_lru_cache.h Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 12, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 12, 2021
tfeher
tfeher commented Jan 12, 2021
View reviewed changes

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bixia1 for the review, I have addressed the issues.

Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/utils/trt_lru_cache.h Resolved
@gbaned
gbaned requested a review from bixia1 January 13, 2021 14:08
@google-ml-butler google-ml-butler Bot removed the ready to pull PR ready for merge process label Jan 13, 2021
@tfeher

tfeher commented Jan 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I have updated the PR to resolve conflicts.

@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 13, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 13, 2021
@copybara-service
copybara-service Bot merged commit ad52469 into tensorflow:master Jan 14, 2021
@tfeher tfeher mentioned this pull request Apr 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bixia1 bixia1 bixia1 approved these changes
@joker-eph joker-eph Awaiting requested review from joker-eph

Assignees

@gbaned gbaned

Labels

cla: yes comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:M CL Change Size: Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tfeher @bixia1 @kokoro-team @gbaned