Repository navigation
[TFTRT - Dynamic Shape Phase 3] Add Dynamic Shape Testing for ConvertArgMinMax - #45862
Merged
copybara-service[bot] merged 1 commit intoJan 12, 2021
Merged
copybara-service[bot] merged 1 commit into
copybara-service[bot] merged 1 commit into
Conversation
DEKHTIARJonathan
changed the title
bixia1
reviewed
Dec 21, 2020
bixia1
left a comment
bixia1
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thanks for working on this!
The test passes with TRT7 but fails with TRT5 though.
Contributor
|
@DEKHTIARJonathan Can you please check @bixia1's comments and keep us posted ? Thanks! |
Contributor
Author
|
@bixia1 I found the issue: I pushed the fix and now it passes on TRT5 & TRT7. Can you please run the CI ? |
bixia1
reviewed
Jan 5, 2021
| return Status::OK(); | ||
| } | ||
|
|
||
| string TrtDimsToTensorShapeString(const nvinfer1::Dims trt_dims, |
Contributor
There was a problem hiding this comment.
How about using absl::StrCat and absl::StrJoin like here
tensorflow/tensorflow/compiler/tf2tensorrt/convert/utils.cc
Lines 122 to 127 in 0c79db0
?
Contributor
Author
There was a problem hiding this comment.
Oh right. I didn't see that function, my bad.
It's fixed ;)
tensorflowbutler
removed
the
stat:awaiting response
Contributor
Author
|
@bixia1 we should be good to go ;) |
bixia1
approved these changes
Jan 12, 2021
google-ml-butler
Bot
added
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bixia1 @tfeher for review
Feature Tracker: #45481