Skip to content

TF-TRT Test ConvertQuantize in dynamic shape mode - #45599

Merged
copybara-service[bot] merged 1 commit into
tensorflow:masterfrom
tfeher:trt_quantize_dynamic
Mar 16, 2021
Merged

copybara-service[bot] merged 1 commit into
tensorflow:masterfrom
tfeher:trt_quantize_dynamic

Conversation

@tfeher

@tfeher tfeher commented Dec 11, 2020

Copy link
Copy Markdown
Contributor

This PR adds explicit batch and dynamic shape mode test to ConvertQuantize.

Tagging @bixia1 for review and @DEKHTIARJonathan for visibility.

Tracker: #45481

@google-ml-butler google-ml-butler Bot added the size:S CL Change Size: Small label Dec 11, 2020
@google-ml-butler
google-ml-butler Bot requested a review from joker-eph December 11, 2020 09:54
@google-cla google-cla Bot added the cla: yes label Dec 11, 2020
@tfeher
tfeher force-pushed the trt_quantize_dynamic branch from 8024bfe to 632a64f Compare December 11, 2020 09:58
@gbaned gbaned self-assigned this Dec 11, 2020
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label Dec 11, 2020
@gbaned
gbaned requested a review from bixia1 December 11, 2020 14:01
@gbaned

gbaned commented Dec 21, 2020

Copy link
Copy Markdown
Contributor

@tfeher Can you please check @DEKHTIARJonathan's comments and keep us posted ? Thanks!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Dec 21, 2020
@gbaned

gbaned commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

@tfeher Any update on this PR? Please. Thanks!

@tensorflowbutler tensorflowbutler added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Jan 22, 2021
@tensorflowbutler

Copy link
Copy Markdown
Member

It has been 15 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

@gbaned

gbaned commented Feb 5, 2021

Copy link
Copy Markdown
Contributor

@tfeher Any update on this PR? Please. Thanks!

1 similar comment
@gbaned

gbaned commented Mar 1, 2021

Copy link
Copy Markdown
Contributor

@tfeher Any update on this PR? Please. Thanks!

@tfeher
tfeher force-pushed the trt_quantize_dynamic branch from 632a64f to 2f53743 Compare March 15, 2021 00:03

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Thanks @DEKHTIARJonathan for the comment, I have updated the PR.

@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 15, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 15, 2021
@copybara-service
copybara-service Bot merged commit e3a2e2c into tensorflow:master Mar 16, 2021
@gbaned gbaned removed the stat:awaiting response Status - Awaiting response from author label Mar 17, 2021
@tfeher
tfeher deleted the trt_quantize_dynamic branch May 16, 2022 08:46
copybara-service Bot pushed a commit that referenced this pull request Jul 14, 2026
Imported from GitHub PR openxla/xla#45599

📝 Summary of Changes
Unify u-test execution script for rocm CI

🎯 Justification
Redirect calls to run_xla.sh and run_multigpu.sh scripts to run_xla_ci_build.sh script

🚀 Kind of Contribution
Please remove what does not apply:  ♻️ Cleanup

📊 Benchmark (for Performance Improvements)
Not relevant

🧪 Unit Tests:
CI

🧪 Execution Tests:
CI
Copybara import of the project:

--
60b218b484b0db74fb842fd7df7d7725296c83d7 by Alexandros Theodoridis <[email protected]>:

Unify testing scripts for ci

Merging this change closes #45599

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#45599 from ROCm:unify_u_test_scripts_in_rocm 60b218b484b0db74fb842fd7df7d7725296c83d7
PiperOrigin-RevId: 947206534
copybara-service Bot pushed a commit that referenced this pull request Jul 14, 2026
Imported from GitHub PR openxla/xla#45599

📝 Summary of Changes
Unify u-test execution script for rocm CI

🎯 Justification
Redirect calls to run_xla.sh and run_multigpu.sh scripts to run_xla_ci_build.sh script

🚀 Kind of Contribution
Please remove what does not apply:  ♻️ Cleanup

📊 Benchmark (for Performance Improvements)
Not relevant

🧪 Unit Tests:
CI

🧪 Execution Tests:
CI
Copybara import of the project:

--
60b218b484b0db74fb842fd7df7d7725296c83d7 by Alexandros Theodoridis <[email protected]>:

Unify testing scripts for ci

Merging this change closes #45599

PiperOrigin-RevId: 947538358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:S CL Change Size: Small stale This label marks the issue/pr stale - to be closed automatically if no activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants