Repository navigation
TF-TRT Slice op converters explicit batch mode - #40736
Merged
copybara-service[bot] merged 1 commit intoMar 16, 2021
Merged
Conversation
Contributor
|
@tfeher Can you please resolve conflicts? Thanks! |
gbaned
added
stat:awaiting response
Contributor
|
@tfeher Any update on this PR? Please. Thanks! |
Contributor
Author
tensorflowbutler
removed
the
stat:awaiting response
DEKHTIARJonathan
requested changes
Dec 12, 2020
Contributor
|
@tfeher Can you please check @DEKHTIARJonathan's comments and keep us posted ? Thanks! |
Contributor
|
@tfeher Any update on this PR? Please. Thanks! |
tensorflowbutler
added
the
stale
Contributor
Author
google-ml-butler
Bot
removed
the
stale
tensorflowbutler
removed
the
stat:awaiting response
tfeher
force-pushed
the
trt_slice_dynamic_shape
branch
from
February 24, 2021 14:57
74a3138 to
c3bf5c6
Compare
Contributor
Author
tfeher
marked this pull request as draft
February 24, 2021 14:59
tfeher
force-pushed
the
trt_slice_dynamic_shape
branch
2 times, most recently
from
March 11, 2021 18:47
6e1f2a8 to
cfaf348
Compare
tfeher
changed the title
tfeher
marked this pull request as ready for review
March 12, 2021 00:22
bixia1
reviewed
Mar 12, 2021
bixia1
left a comment
bixia1
left a comment
Contributor
There was a problem hiding this comment.
Still working on the reviewing, but would like to send out the comment I have so far. I also modified the PR description. Would you please check?
tfeher
commented
Mar 14, 2021
tfeher
force-pushed
the
trt_slice_dynamic_shape
branch
from
March 14, 2021 23:06
806d1ec to
ff1ff91
Compare
bixia1
reviewed
Mar 15, 2021
… mode Additionally, allow negative stride values.
tfeher
force-pushed
the
trt_slice_dynamic_shape
branch
from
March 16, 2021 00:10
ff1ff91 to
2b1d2b0
Compare
tfeher
commented
Mar 16, 2021
bixia1
approved these changes
Mar 16, 2021
google-ml-butler
Bot
added
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables Slice and StridedSlice op conversion in explicit batch mode.
We currently enable the conversion only for the cases where the slice parameters (begin, size) can be calculated at conversion time. For other cases, we would need to use shape layers to calculate the slice parameters at runtime. We will implement this in a follow up PR.
The StridedSlice converter was improved to accept negative stride, and corresponding tests were added.
Tagging @bixia1 for review.