Repository navigation
[TFTRT] Add Dynamic Shape Testing for ConvertSquare - #40483
Merged
tensorflow-copybara merged 1 commit intoJun 18, 2020
Merged
Conversation
gbaned
added
comp:gpu:tensorrt
bixia1
self-requested a review
June 17, 2020 18:20
bixia1
approved these changes
Jun 17, 2020
| const auto& inputs = params->inputs; | ||
| const auto& node_def = params->node_def; | ||
| TF_RETURN_IF_ERROR(CheckInputsWeights(*params, {{"x", false}})); | ||
| #if IS_TRT_VERSION_GE(6, 0, 1, 0) |
Contributor
There was a problem hiding this comment.
We have a plan to provide a way to get the supported data types for all op converters. The code here is fine for this reason.
google-ml-butler
Bot
added
kokoro:force-run
bixia1
requested changes
Jun 17, 2020
bixia1
left a comment
bixia1
left a comment
Contributor
There was a problem hiding this comment.
would you please squash the commits into one commit?
Co-authored-by: Tamas Feher <[email protected]> - Modify ConvertSquare tests to use newer TFTRT testing API - Add INT32 as a supported dtype for TFTRT ConvertSquare
MattConley
force-pushed
the
convert_square_update
branch
from
June 17, 2020 19:58
a371f5a to
cb61c42
Compare
Contributor
Author
|
Thanks for the review, the changes have been consolidated into one commit |
bixia1
approved these changes
Jun 17, 2020
google-ml-butler
Bot
added
kokoro:force-run
rthadur
removed
awaiting review
rthadur
approved these changes
Jun 18, 2020
google-ml-butler
Bot
added
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the ConvertSquare test to use the new testing API