Skip to content

TF-TRT reduction op converter tests - #40201

Merged
tensorflow-copybara merged 1 commit into
tensorflow:masterfrom
tfeher:trt_reduce_dynamic_shape
Aug 5, 2020
Merged

TF-TRT reduction op converter tests#40201
tensorflow-copybara merged 1 commit into
tensorflow:masterfrom
tfeher:trt_reduce_dynamic_shape

Conversation

@tfeher

@tfeher tfeher commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

This PR adds unit test for the reduce op converters. Tagging @bixia1 for review.

@google-ml-butler google-ml-butler Bot added the size:L CL Change Size: Large label Jun 5, 2020
@google-ml-butler
google-ml-butler Bot requested a review from joker-eph June 5, 2020 17:49
@gbaned gbaned self-assigned this Jun 6, 2020
@gbaned gbaned added the awaiting review Pull request awaiting review label Jun 12, 2020
@gbaned

gbaned commented Jun 17, 2020

Copy link
Copy Markdown
Contributor

@tfeher Can you please resolve conflicts? Thanks!

@gbaned gbaned added stat:awaiting response Status - Awaiting response from author and removed awaiting review Pull request awaiting review labels Jun 17, 2020
@tensorflowbutler tensorflowbutler added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Jul 9, 2020
@tensorflowbutler

tensorflowbutler commented Jul 9, 2020

Copy link
Copy Markdown
Member

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

@tfeher

tfeher commented Jul 9, 2020

Copy link
Copy Markdown
Contributor Author

Sorry for the delay. I will update the PR soon. This, and many of the TF-TRT PRs that I have opened, are part of a large series of PRs that update / improve all the TF-TRT op converter tests. I will work on this as soon as some open issues are fixed in other related PRs.

@google-ml-butler google-ml-butler Bot removed the stale This label marks the issue/pr stale - to be closed automatically if no activity label Jul 9, 2020
@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Jul 11, 2020
@tfeher
tfeher force-pushed the trt_reduce_dynamic_shape branch 2 times, most recently from ccd9b75 to df7276a Compare July 11, 2020 22:33
@gbaned
gbaned requested a review from bixia1 July 14, 2020 12:01
@gbaned gbaned added awaiting review Pull request awaiting review comp:gpu:tensorrt Issues specific to TensorRT labels Jul 14, 2020
bixia1
bixia1 reviewed Jul 21, 2020
View reviewed changes
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
@gbaned gbaned removed the awaiting review Pull request awaiting review label Jul 21, 2020
@gbaned

gbaned commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

@tfeher Can you please check @bixia1's comments and keep us posted ? Thanks!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Jul 24, 2020
tfeher
tfeher commented Aug 4, 2020
View reviewed changes

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bixia1 for the review, I have addressed the issues.

Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc Resolved
@tfeher
tfeher force-pushed the trt_reduce_dynamic_shape branch from df7276a to 3b6172f Compare August 4, 2020 14:54
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 4, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 4, 2020
@gbaned gbaned removed the stat:awaiting response Status - Awaiting response from author label Aug 5, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Aug 5, 2020
@tensorflow-copybara
tensorflow-copybara merged commit 2cc892f into tensorflow:master Aug 5, 2020
@tfeher tfeher mentioned this pull request Dec 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bixia1 bixia1 bixia1 approved these changes
@joker-eph joker-eph Awaiting requested review from joker-eph

Assignees

@gbaned gbaned

Labels

cla: yes comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:L CL Change Size: Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tfeher @gbaned @tensorflowbutler @bixia1 @googlebot @kokoro-team @tensorflow-copybara