Skip to content

TF-TRT Improve test coverage of pool op converters - #40184

Merged
tensorflow-copybara merged 1 commit into
tensorflow:masterfrom
tfeher:trt_maxpool_dynamic_shape
Jul 13, 2020
Merged

tensorflow-copybara merged 1 commit into
tensorflow:masterfrom
tfeher:trt_maxpool_dynamic_shape

Conversation

@tfeher

@tfeher tfeher commented Jun 5, 2020

Copy link
Copy Markdown
Contributor
  • Add dynamic shape and explicit batch tests for 3D pool ops.
  • Extend the test to cover 2D pool ops

@google-ml-butler google-ml-butler Bot added the size:L CL Change Size: Large label Jun 5, 2020
@google-ml-butler
google-ml-butler Bot requested a review from joker-eph June 5, 2020 09:30
@gbaned gbaned self-assigned this Jun 5, 2020
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label Jun 5, 2020
@gbaned
gbaned requested a review from bixia1 June 5, 2020 09:45
@gbaned gbaned added the awaiting review Pull request awaiting review label Jun 8, 2020
@tfeher
tfeher force-pushed the trt_maxpool_dynamic_shape branch from e1183a5 to b3ff87b Compare June 25, 2020 19:47
@gbaned gbaned removed the awaiting review Pull request awaiting review label Jun 26, 2020
@gbaned

gbaned commented Jun 29, 2020

Copy link
Copy Markdown
Contributor

@tfeher Can you please check @bixia1's comments and keep us posted. Thanks!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Jun 29, 2020

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bixia1 for the review, I have addressed the issues.

@tfeher
tfeher force-pushed the trt_maxpool_dynamic_shape branch from b3ff87b to 4661a4f Compare July 6, 2020 21:53
@gbaned gbaned removed the stat:awaiting response Status - Awaiting response from author label Jul 7, 2020
@gbaned
gbaned requested a review from bixia1 July 7, 2020 15:12
@gbaned gbaned added the awaiting review Pull request awaiting review label Jul 9, 2020
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 13, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 13, 2020
@gbaned gbaned removed the awaiting review Pull request awaiting review label Jul 13, 2020
@tensorflow-copybara
tensorflow-copybara merged commit 07073dc into tensorflow:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:L CL Change Size: Large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants