Repository navigation
TF-TRT test FusedBatchNorm op converter - #40179
Merged
tensorflow-copybara merged 1 commit intoJul 20, 2020
Merged
tensorflow-copybara merged 1 commit into
tensorflow-copybara merged 1 commit into
Conversation
Contributor
|
@bixia1 Can you please review this PR ? Thanks! |
tfeher
force-pushed
the
trt_fusedbatchnorm_dynamic_shape
branch
from
July 6, 2020 22:01
d91140e to
9eb20bb
Compare
bixia1
reviewed
Jul 7, 2020
Contributor
gbaned
added
awaiting review
tfeher
force-pushed
the
trt_fusedbatchnorm_dynamic_shape
branch
from
July 11, 2020 21:16
9eb20bb to
6327c63
Compare
tfeher
commented
Jul 11, 2020
bixia1
approved these changes
Jul 13, 2020
google-ml-butler
Bot
added
kokoro:force-run
bixia1
requested changes
Jul 13, 2020
bixia1
left a comment
bixia1
left a comment
Contributor
There was a problem hiding this comment.
Sorry. I was in the process of merging this and realize that I need to make non-trivial changes to the comment for ConvertFusedBatchNorm. Need to get your agreement on this.
Contributor
tfeher
force-pushed
the
trt_fusedbatchnorm_dynamic_shape
branch
from
July 20, 2020 14:58
6327c63 to
45591fa
Compare
Contributor
Author
|
Thanks @bixia1, I have made the requested changes. |
bixia1
approved these changes
Jul 20, 2020
google-ml-butler
Bot
added
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test for the FusedBatchNorm op converter in implicit batch, explicit batch and dynamic shape mode. Tagging @bixia1 for review.