Skip to content

TF-TRT Pack op conversion in dynamic shape mode - #39859

Merged
tensorflow-copybara merged 1 commit into
tensorflow:masterfrom
tfeher:trt_pack_dynamic_shape
Jul 1, 2020
Merged

tensorflow-copybara merged 1 commit into
tensorflow:masterfrom
tfeher:trt_pack_dynamic_shape

Conversation

@tfeher

@tfeher tfeher commented May 25, 2020

Copy link
Copy Markdown
Contributor

This PR improves the Pack (Stack) op converter to handle explicit batch and dynamic shape input data. Tagging @bixia1 for review.

@google-ml-butler google-ml-butler Bot added the size:L CL Change Size: Large label May 25, 2020
@google-ml-butler
google-ml-butler Bot requested a review from joker-eph May 25, 2020 21:31
@gbaned gbaned self-assigned this May 26, 2020
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label May 26, 2020
@gbaned
gbaned requested a review from bixia1 May 26, 2020 04:17
@gbaned

gbaned commented Jun 2, 2020

Copy link
Copy Markdown
Contributor

@tfeher Can you please resolve conflicts? Thanks!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Jun 2, 2020
@tfeher
tfeher force-pushed the trt_pack_dynamic_shape branch 2 times, most recently from 8c315e7 to 9d6fcf7 Compare June 19, 2020 12:48
@gbaned

gbaned commented Jun 29, 2020

Copy link
Copy Markdown
Contributor

@tfeher Can you please check @bixia1's comments and keep us posted. Thanks!

@tfeher
tfeher force-pushed the trt_pack_dynamic_shape branch from 9d6fcf7 to bfe4330 Compare June 30, 2020 18:32

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bixia1 for the review, I have addressed the issues.

@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 30, 2020
@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Jun 30, 2020
@gbaned gbaned removed cla: yes stat:awaiting response Status - Awaiting response from author labels Jul 1, 2020
@tensorflow-copybara
tensorflow-copybara merged commit 2c22c73 into tensorflow:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:L CL Change Size: Large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants