Skip to content

TF-TRT GatherV2 op conversion dynamic shape mode - #39848

Merged
tensorflow-copybara merged 2 commits into
tensorflow:masterfrom
tfeher:trt_gather_dynamic_shapes
Jun 5, 2020
Merged

tensorflow-copybara merged 2 commits into
tensorflow:masterfrom
tfeher:trt_gather_dynamic_shapes

Conversation

@tfeher

@tfeher tfeher commented May 25, 2020

Copy link
Copy Markdown
Contributor

This PR improves the GatherV2 op converter to handle explicit batch and dynamic shape input data.
Additionally:

  • fix testing validation errors
  • enable defining implicit batch test with inconsistent batch size
  • improve converter helper routine for tensor/weight argument check

Tagging @bixia1 for review

@google-ml-butler google-ml-butler Bot added the size:L CL Change Size: Large label May 25, 2020
@google-ml-butler
google-ml-butler Bot requested a review from joker-eph May 25, 2020 11:27
@gbaned gbaned self-assigned this May 26, 2020
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label May 26, 2020
@gbaned
gbaned requested a review from bixia1 May 26, 2020 04:16
@gbaned

gbaned commented Jun 2, 2020 •

Copy link
Copy Markdown
Contributor

@tfeher Can you please resolve conflicts? Thanks!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Jun 2, 2020
@tfeher
tfeher force-pushed the trt_gather_dynamic_shapes branch from 3836c8d to adaf01c Compare June 4, 2020 15:20
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 5, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 5, 2020
@tensorflow-copybara
tensorflow-copybara merged commit d32b9c8 into tensorflow:master Jun 5, 2020
@gbaned gbaned removed the stat:awaiting response Status - Awaiting response from author label Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:L CL Change Size: Large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants