Skip to content

TF-TRT test SquaredDiff op conversion in dynamic shape mode - #39758

Merged
tensorflow-copybara merged 1 commit into
tensorflow:masterfrom
tfeher:trt_squared_diff_dynamic_shape
Jun 17, 2020
Merged

tensorflow-copybara merged 1 commit into
tensorflow:masterfrom
tfeher:trt_squared_diff_dynamic_shape

Conversation

@tfeher

@tfeher tfeher commented May 21, 2020

Copy link
Copy Markdown
Contributor

This PR adds explicit batch and dynamic shape tests to the SquaredDiff op converter. Tagging @bixia1 for review.

@google-ml-butler google-ml-butler Bot added the size:M CL Change Size: Medium label May 21, 2020
@google-ml-butler
google-ml-butler Bot requested a review from joker-eph May 21, 2020 14:37
@gbaned gbaned self-assigned this May 21, 2020
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label May 21, 2020
@gbaned
gbaned requested a review from bixia1 May 21, 2020 15:03
@tfeher
tfeher force-pushed the trt_squared_diff_dynamic_shape branch from b664728 to 477a76a Compare May 22, 2020 09:30
@gbaned gbaned added the awaiting review Pull request awaiting review label May 27, 2020
@tfeher
tfeher force-pushed the trt_squared_diff_dynamic_shape branch from 477a76a to 0dd0102 Compare May 28, 2020 16:16
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Jun 3, 2020

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bixia1 for the review, I have answered the question.

@tfeher
tfeher force-pushed the trt_squared_diff_dynamic_shape branch from 94b67fd to e1dc0b8 Compare June 4, 2020 14:48
@gbaned
gbaned requested a review from bixia1 June 8, 2020 17:16
@gbaned gbaned added the awaiting review Pull request awaiting review label Jun 12, 2020

@bixia1 bixia1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash the commits into one? I will take care of the merge after.

Additionally the runtime error handling is improved:
- Do not check runtime error details in TF-TRT op converter test
- Report an error if invalid dimension is found
@tfeher
tfeher force-pushed the trt_squared_diff_dynamic_shape branch from 0aef82a to ade1448 Compare June 16, 2020 22:44
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 17, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 17, 2020
@tensorflow-copybara
tensorflow-copybara merged commit 78ecbb0 into tensorflow:master Jun 17, 2020
@gbaned gbaned removed the awaiting review Pull request awaiting review label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:M CL Change Size: Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants