Skip to content

TF-TRT ExpandDims converter dynamic shape mode - #39282

Merged
tensorflow-copybara merged 2 commits into
tensorflow:masterfrom
tfeher:trt_expanddims_dynamic_shape
Jun 4, 2020
Merged

TF-TRT ExpandDims converter dynamic shape mode#39282
tensorflow-copybara merged 2 commits into
tensorflow:masterfrom
tfeher:trt_expanddims_dynamic_shape

Conversation

@tfeher

@tfeher tfeher commented May 7, 2020

Copy link
Copy Markdown
Contributor

This PR improves the ExpandDims op converter to handle explicit batch and dynamic shape input data.

Tagging @bixia1 for review.

@google-ml-butler google-ml-butler Bot added the size:L CL Change Size: Large label May 7, 2020
@google-ml-butler
google-ml-butler Bot requested a review from joker-eph May 7, 2020 20:52
@bixia1
bixia1 self-requested a review May 7, 2020 23:45
@gbaned gbaned self-assigned this May 8, 2020
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label May 8, 2020
bixia1
bixia1 reviewed May 8, 2020
View reviewed changes
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
@gbaned

gbaned commented May 12, 2020

Copy link
Copy Markdown
Contributor

@tfeher Can you please check @bixia1's comments and keep us posted. Thanks!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label May 12, 2020
@tfeher
tfeher force-pushed the trt_expanddims_dynamic_shape branch from e953c32 to aa19b84 Compare May 20, 2020 22:36
@gbaned gbaned removed the stat:awaiting response Status - Awaiting response from author label May 27, 2020
@gbaned
gbaned requested a review from bixia1 May 27, 2020 13:01
@tfeher
tfeher force-pushed the trt_expanddims_dynamic_shape branch from aa19b84 to 472d89f Compare May 28, 2020 13:46
tfeher
tfeher commented May 28, 2020
View reviewed changes

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bixia1 for the comments, I have addressed the issues.
I have also applied the tf_dtype -> tf_type name change as requested here.

Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
@tfeher
tfeher force-pushed the trt_expanddims_dynamic_shape branch from 472d89f to c2b63f1 Compare May 28, 2020 14:03
bixia1
bixia1 reviewed May 29, 2020
View reviewed changes
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
@gbaned

gbaned commented Jun 1, 2020

Copy link
Copy Markdown
Contributor

@tfeher Can you please check @bixia1's comments and keep us posted. Thanks!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Jun 2, 2020
@tfeher
tfeher force-pushed the trt_expanddims_dynamic_shape branch from c2b63f1 to 1aafdca Compare June 3, 2020 11:06
tfeher
tfeher commented Jun 3, 2020
View reviewed changes

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bixia1 for the constructive comments! I have addressed the issues, please have a look.

Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
@tfeher
tfeher force-pushed the trt_expanddims_dynamic_shape branch from 1aafdca to 177625f Compare June 3, 2020 20:59
tfeher
tfeher commented Jun 3, 2020
View reviewed changes

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed the remaining issues.

Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
Comment thread tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Resolved
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 3, 2020
@tensorflow-copybara
tensorflow-copybara merged commit 97b27af into tensorflow:master Jun 4, 2020
@tfeher tfeher mentioned this pull request Mar 16, 2021
Closed
@tfeher
tfeher deleted the trt_expanddims_dynamic_shape branch May 16, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bixia1 bixia1 bixia1 approved these changes
@joker-eph joker-eph Awaiting requested review from joker-eph

Assignees

@gbaned gbaned

Labels

cla: yes comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:L CL Change Size: Large stat:awaiting response Status - Awaiting response from author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tfeher @gbaned @bixia1 @googlebot @kokoro-team @tensorflow-copybara