Skip to content

TF-TRT enable BiasAdd op in dynamic shape mode - #39156

Merged
tensorflow-copybara merged 1 commit into
tensorflow:masterfrom
tfeher:trt_biasadd_dynamic_shape
May 27, 2020
Merged

tensorflow-copybara merged 1 commit into
tensorflow:masterfrom
tfeher:trt_biasadd_dynamic_shape

Conversation

@tfeher

@tfeher tfeher commented May 4, 2020

Copy link
Copy Markdown
Contributor

Improve the converter of BiasAdd to handle explicit batch mode, and test it both in explicit batch and dynamic shape mode.

Tagging @bixia1 for review.

@google-ml-butler google-ml-butler Bot added the size:L CL Change Size: Large label May 4, 2020
@google-ml-butler
google-ml-butler Bot requested a review from joker-eph May 4, 2020 13:55
@gbaned gbaned self-assigned this May 4, 2020
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label May 4, 2020
@gbaned
gbaned requested a review from bixia1 May 4, 2020 15:34
@gbaned gbaned added the awaiting review Pull request awaiting review label May 8, 2020
@tfeher
tfeher force-pushed the trt_biasadd_dynamic_shape branch from c8fb78c to 743b62c Compare May 8, 2020 20:42
@gbaned

gbaned commented May 19, 2020

Copy link
Copy Markdown
Contributor

@tfeher Can you please resolve conflicts? Thanks!

@gbaned gbaned added stat:awaiting response Status - Awaiting response from author and removed awaiting review Pull request awaiting review labels May 19, 2020
@tfeher
tfeher force-pushed the trt_biasadd_dynamic_shape branch 2 times, most recently from d57ed8a to 202f1cd Compare May 21, 2020 13:53
@gbaned gbaned removed the stat:awaiting response Status - Awaiting response from author label May 22, 2020
@tfeher
tfeher force-pushed the trt_biasadd_dynamic_shape branch from 202f1cd to d847948 Compare May 26, 2020 21:02

@tfeher tfeher left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bixia1 for the review, I have addressed the issues. Let me know if there are other places which needs improvements.

@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 27, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 27, 2020
@tensorflow-copybara
tensorflow-copybara merged commit be4d17c into tensorflow:master May 27, 2020
@tfeher
tfeher deleted the trt_biasadd_dynamic_shape branch May 16, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:L CL Change Size: Large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants