Repository navigation
TF-TRT test activation converter - #39155
Merged
tensorflow-copybara merged 1 commit intoMay 20, 2020
Merged
Conversation
tfeher
force-pushed
the
trt_activation_dynamic_shape
branch
from
May 7, 2020 19:52
2147c04 to
aafacb8
Compare
Contributor
Author
|
bixia1
reviewed
May 15, 2020
tfeher
commented
May 15, 2020
Contributor
|
@tfeher Can you please resolve conflicts? Thanks! |
Additionally helper functions for dynamic shape tests are improved: - Added test parameter member variables to ParameterizedOpConverterTestBase - Single TetOpConverter function introduced - Type parameter handling for input tensors simplified
tfeher
force-pushed
the
trt_activation_dynamic_shape
branch
from
May 19, 2020 21:31
418148d to
dc0149a
Compare
tfeher
commented
May 19, 2020
bixia1
approved these changes
May 20, 2020
google-ml-butler
Bot
added
kokoro:force-run
copybara-service Bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
Imported from GitHub PR openxla/xla#39155 📝 Summary of Changes Replaces `reinterpret_cast` with `std::memcpy` to avoid U.B. Implementation of Get_State was not setting state pointer when using the backward compatibility path 🎯 Justification Support state with V0.2 FFI in latest JAX. 🚀 Kind of Contribution 🐛 Bug Fix Copybara import of the project: -- b0bed02a0aa43ff92219ba2b1aa4ddf64306e1ca by Michael Goldfarb <[email protected]>: Fix UB in state get/set when using backwards compat mode. Also fixes the implementation to correctly set the state. -- d18d5b6bc35632fe2984021f43d9b1414d4c7c3b by Michael Goldfarb <[email protected]>: Fix write to state. Merging this change closes #39155 Reverts 95aacc5 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#39155 from mgoldfarb-nvidia:mgoldfarb/fix_ffi_backwards_compat_bug_state d18d5b6bc35632fe2984021f43d9b1414d4c7c3b PiperOrigin-RevId: 883152448
copybara-service Bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
Imported from GitHub PR openxla/xla#39155 📝 Summary of Changes Replaces `reinterpret_cast` with `std::memcpy` to avoid U.B. Implementation of Get_State was not setting state pointer when using the backward compatibility path 🎯 Justification Support state with V0.2 FFI in latest JAX. 🚀 Kind of Contribution 🐛 Bug Fix Copybara import of the project: -- b0bed02a0aa43ff92219ba2b1aa4ddf64306e1ca by Michael Goldfarb <[email protected]>: Fix UB in state get/set when using backwards compat mode. Also fixes the implementation to correctly set the state. -- d18d5b6bc35632fe2984021f43d9b1414d4c7c3b by Michael Goldfarb <[email protected]>: Fix write to state. Merging this change closes #39155 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#39155 from mgoldfarb-nvidia:mgoldfarb/fix_ffi_backwards_compat_bug_state d18d5b6bc35632fe2984021f43d9b1414d4c7c3b PiperOrigin-RevId: 883152448
copybara-service Bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
Imported from GitHub PR openxla/xla#39155 📝 Summary of Changes Replaces `reinterpret_cast` with `std::memcpy` to avoid U.B. Implementation of Get_State was not setting state pointer when using the backward compatibility path 🎯 Justification Support state with V0.2 FFI in latest JAX. 🚀 Kind of Contribution 🐛 Bug Fix Copybara import of the project: -- b0bed02a0aa43ff92219ba2b1aa4ddf64306e1ca by Michael Goldfarb <[email protected]>: Fix UB in state get/set when using backwards compat mode. Also fixes the implementation to correctly set the state. -- d18d5b6bc35632fe2984021f43d9b1414d4c7c3b by Michael Goldfarb <[email protected]>: Fix write to state. Merging this change closes #39155 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#39155 from mgoldfarb-nvidia:mgoldfarb/fix_ffi_backwards_compat_bug_state d18d5b6bc35632fe2984021f43d9b1414d4c7c3b PiperOrigin-RevId: 883152448
copybara-service Bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
Imported from GitHub PR openxla/xla#39155 📝 Summary of Changes Replaces `reinterpret_cast` with `std::memcpy` to avoid U.B. Implementation of Get_State was not setting state pointer when using the backward compatibility path 🎯 Justification Support state with V0.2 FFI in latest JAX. 🚀 Kind of Contribution 🐛 Bug Fix Copybara import of the project: -- b0bed02a0aa43ff92219ba2b1aa4ddf64306e1ca by Michael Goldfarb <[email protected]>: Fix UB in state get/set when using backwards compat mode. Also fixes the implementation to correctly set the state. -- d18d5b6bc35632fe2984021f43d9b1414d4c7c3b by Michael Goldfarb <[email protected]>: Fix write to state. Merging this change closes #39155 PiperOrigin-RevId: 884428841
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds dynamic shape and explicit batch tests for the activation ops.
Tagging @bixia1 for review