Skip to content

Use Unified Memory in TRT opconverter tests - #38124

Merged
tensorflow-copybara merged 2 commits into
tensorflow:masterfrom
tfeher:trt_opconv_test_unified_memory
Apr 16, 2020
Merged

tensorflow-copybara merged 2 commits into
tensorflow:masterfrom
tfeher:trt_opconv_test_unified_memory

Conversation

@tfeher

@tfeher tfeher commented Apr 1, 2020

Copy link
Copy Markdown
Contributor

TRT's opconverter unit tests are changed in this PR to use unified memory when creating test tensors. This simplifies BuildAndRun, since copying the data between GPU and host is done automatically by the driver.

Switching to unified memory is achieved by moving the AsTensor and ConstructTensor functions inside the OpConverterTest class and using GpuManagedAllocator in them.

This PR is based on #38118, please review that first.

@tensorflow-bot tensorflow-bot Bot added the size:L CL Change Size: Large label Apr 1, 2020
@gbaned gbaned self-assigned this Apr 1, 2020
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label Apr 1, 2020
@gbaned
gbaned requested a review from bixia1 April 1, 2020 15:06
@gbaned gbaned added the awaiting review Pull request awaiting review label Apr 6, 2020
@google-ml-butler google-ml-butler Bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 15, 2020
@tensorflow-copybara
tensorflow-copybara merged commit 4735df8 into tensorflow:master Apr 16, 2020
@gbaned gbaned removed the awaiting review Pull request awaiting review label Apr 16, 2020
@tfeher
tfeher deleted the trt_opconv_test_unified_memory branch May 16, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:L CL Change Size: Large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants