Repository navigation
Fix go proto handling - #36387
Merged
Merged
Fix go proto handling#36387
Conversation
frankchn
approved these changes
Jan 31, 2020
tensorflow-bot
Bot
added
kokoro:force-run
ArmageddonKnight
pushed a commit
to UofT-EcoSystem/tensorflow
that referenced
this pull request
Feb 4, 2020
PiperOrigin-RevId: 293046050 Change-Id: Ia81bf682f62293faa591d6de191dbeda3fed7138
|
Tested out the solution by building from source. This seems to now cause an import cycle. |
Contributor
|
@JWMHayhurst can you file a bug with what you are running and the error message? |
Contributor
Author
|
I have a change out to fix the import cycle. Will submit today. |
Contributor
Author
|
Fixed in 4221d1a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35133 and #34580