Patch @com_google_absl to always export //absl/time:time symbols#34044
Merged
tensorflow-copybara merged 2 commits intotensorflow:masterfrom Nov 11, 2019
Merged
Patch @com_google_absl to always export //absl/time:time symbols#34044tensorflow-copybara merged 2 commits intotensorflow:masterfrom
tensorflow-copybara merged 2 commits intotensorflow:masterfrom
Conversation
mihaimaruseac
suggested changes
Nov 6, 2019
Contributor
mihaimaruseac
left a comment
mihaimaruseac
left a comment
There was a problem hiding this comment.
Looks good to me. However, there is only one patch_file but two mentioned in the comment. Can you instead edit the comment to specify something like "Remove everything but the patch to absl/time/BUILD.bazel until ABSL issue is resolved. Remove the patch to absl/time/BUILD.bazel when.."
Speaking of which, let's add some more detail about the export symbols issues. A link to another issue should be enough
Contributor
Author
|
Rephrased the comment, PTAL. |
tensorflow-bot
bot
added
kokoro:force-run
Member
|
Hmmm seems there was a copybara error? Gentle bump to see if this can get through as it's breaking our pin to nightly. |
gbaned
added
ready to pull
ArmageddonKnight
pushed a commit
to UofT-EcoSystem/tensorflow
that referenced
this pull request
Nov 11, 2019
PiperOrigin-RevId: 279783115 Change-Id: I9da69667b4e250792666c02636bdc77ece165990
Contributor
|
This is breaking internal builds |
tensorflow-copybara
pushed a commit
that referenced
this pull request
Nov 13, 2019
…ymbols Imported from GitHub PR #34044 This should fix tensorflow/addons#663, caused by changing logic in Bazel on which symbols we export (see bazelbuild/bazel#7362). Copybara import of the project: PiperOrigin-RevId: 280275294 Change-Id: I1a21010f47367f66ab33ba51aefe5226f8191b30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix tensorflow/addons#663, caused by changing logic in Bazel on which symbols we export (see bazelbuild/bazel#7362).