Skip to content

build: Support Bazel 1.0#33240

Closed
byronyi wants to merge 1 commit intotensorflow:masterfrom
byronyi:bazel-1-0-upgrade
Closed

build: Support Bazel 1.0#33240
byronyi wants to merge 1 commit intotensorflow:masterfrom
byronyi:bazel-1-0-upgrade

Conversation

@byronyi
Copy link
Contributor

@byronyi byronyi commented Oct 11, 2019

Ping @gunan @seanpmorgan @dslomov; is there any known blockers?

Signed-off-by: Bairen Yi <[email protected]>
@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Oct 11, 2019
@gbaned gbaned self-assigned this Oct 11, 2019
@gbaned gbaned requested a review from gunan October 11, 2019 09:33
@dslomov
Copy link

dslomov commented Oct 11, 2019

/cc @meteorcloudy @laszlocsomor

@meteorcloudy
Copy link
Member

@byronyi I'm upgrading Bazel to 0.29.1 for TF internally, because TensorFlow is in the middle of 1.15 release, I can not submit the change yet. After it's done, I'll try to upgrade Bazel to 1.0, but there might be some incompatible changes in 1.0 we need to adapt.

@laszlocsomor
Copy link
Contributor

@meteorcloudy , how can I help?

@meteorcloudy
Copy link
Member

meteorcloudy commented Oct 14, 2019

@laszlocsomor I'll finish the work to upgrading Bazel to 0.29.1. Can you help making TensorFlow build with Bazel 1.0? Currently the build is red after we released 1.0 and TensorFlow is temporarily disabled at Bazel's Downstream pipeline. I believe the main blocker is #32835.

@gbaned gbaned added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Oct 25, 2019
@gbaned
Copy link
Contributor

gbaned commented Dec 10, 2019

@laszlocsomor Any update on this PR, please.

@byronyi
Copy link
Contributor Author

byronyi commented Dec 10, 2019

@gbaned This is staled as TF builds with Bazel >= 1.1.0.

Closing for now.

@byronyi byronyi closed this Dec 10, 2019
@byronyi byronyi deleted the bazel-1-0-upgrade branch December 10, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes size:S CL Change Size: Small stat:awaiting tensorflower Status - Awaiting response from tensorflower

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants