Testing new Eigen version in isolation #2409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…machines with many cpu cores For example, the wall time for the following tutorial went down from 13m35 to 5m27: bazel run -c opt --copt=-mavx tensorflow/examples/tutorials/word2vec/word2vec_basic Change: 122462177
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Contributor
Author
|
@tensorflow-jenkins test this please. |
tensorflow-copybara
pushed a commit
that referenced
this pull request
Aug 21, 2020
Backward compatible change preparing for pybind11 update. Hidden (and luckily inconsequential) bugs discovered while testing with the current pybind11 github master branch, and current pybind/pybind11#2409 applied locally. The code changed in this CL depends on a pybind11 mis-feature: Current `stable` `pybind11::str` can hold either `PyUnicodeObject` (as documented) or `PyBytesObject` (undocumented and probably very surprising), even under Python 3. pybind PR #2409 changes `pybind11::str` so that it can only hold `PyUnicodeObject`. PiperOrigin-RevId: 327849650 Change-Id: I2a119479a6af8ab8ec5315a1b8565e96952b84c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change: 122462177