Repository navigation
Migrate IFRT host-buffer cleanup callbacks to std::shared_ptr<const void>. - #130334
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
exported_pr_1021526713
branch
from
November 14, 2026 09:29
787a955 to
3ad2132
Compare
…oid>. `xla::ifrt::Client::MakeArrayFromHostBuffer` and `MakeArraysFromHostBufferShards` previously documented that `on_done_with_host_buffer` and `HostBuffer::on_done` were invoked only when `OK` was returned, while implementations wrapped or executed them mid-call before validation and multi-shard creation completed. In addition, invoking `std::move(fn)()` on `std::function<void()>` left closure-captured host buffers alive until the enclosing `std::function` or `BasicStringArray` was destroyed. Switch `MakeArrayFromHostBuffer` (renaming `on_done_with_host_buffer` to `host_buffer_hold`), `Client::HostBuffer::on_done`, and `BasicStringArray::OnDoneWithBuffer` to `std::shared_ptr<const void>` (with `MakeSharedCleanup` for callable-based cleanup) so ownership transfers unconditionally to the callee, cleanup runs deterministically on both success and failure once all readers finish accessing `data`, and callers already holding `std::shared_ptr` buffers pass them directly without extra wrapper allocations. PiperOrigin-RevId: 1021526713
copybara-service
Bot
force-pushed
the
exported_pr_1021526713
branch
from
November 14, 2026 10:47
3ad2132 to
0e61f5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate IFRT host-buffer cleanup callbacks to std::shared_ptr.
xla::ifrt::Client::MakeArrayFromHostBufferandMakeArraysFromHostBufferShardspreviously documented thaton_done_with_host_bufferandHostBuffer::on_donewere invoked only whenOKwas returned, while implementations wrapped or executed them mid-call before validation and multi-shard creation completed. In addition, invokingstd::move(fn)()onstd::function<void()>left closure-captured host buffers alive until the enclosingstd::functionorBasicStringArraywas destroyed.Switch
MakeArrayFromHostBuffer(renamingon_done_with_host_buffertohost_buffer_hold),Client::HostBuffer::on_done, andBasicStringArray::OnDoneWithBuffertostd::shared_ptr<const void>(withMakeSharedCleanupfor callable-based cleanup) so ownership transfers unconditionally to the callee, cleanup runs deterministically on both success and failure once all readers finish accessingdata, and callers already holdingstd::shared_ptrbuffers pass them directly without extra wrapper allocations.