Repository navigation
Enforce authorization in tf.data service RPC handlers. - #130331
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Add a virtual `Authorize(const grpc::AuthContext*)` hook to `CredentialsFactory` and invoke it in the RPC handler macros of `GrpcDispatcherImpl`, `GrpcWorkerImpl`, and `FastrakGrpcService` before dispatching requests. Implement `Loas2CredentialsFactory::Authorize` to require an authenticated peer whose `GRPC_LOAS_MDB_USER_PROPERTY_NAME` matches the server process owner, and route in-process state queries in `DispatchGrpcDataServer` and `WorkerGrpcDataServer` directly through `impl()` instead of constructing unauthenticated `ServerContext` instances. PiperOrigin-RevId: 1021247208
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce authorization in tf.data service RPC handlers.
Add a virtual
Authorize(const grpc::AuthContext*)hook toCredentialsFactoryand invoke it in the RPC handler macros ofGrpcDispatcherImpl,GrpcWorkerImpl, andFastrakGrpcServicebeforedispatching requests. Implement
Loas2CredentialsFactory::Authorizetorequire an authenticated peer whose
GRPC_LOAS_MDB_USER_PROPERTY_NAMEmatches the server process owner, and route in-process state queries in
DispatchGrpcDataServerandWorkerGrpcDataServerdirectly throughimpl()instead of constructing unauthenticatedServerContextinstances.