Add support for Linux RISC-V 64 by IgnotaYun · Pull Request #102607 · tensorflow/tensorflow

IgnotaYun · 2025-10-20T12:51:52Z

This commit fixes #102159 which prevented TensorFlow from compiling on RISC-V 64 due to missing codepath in the build system.

RFC: Currently this patch overrides timeout of rules_python for all platforms which is obviously not ideal. How do we set pip package timeout here in Tensorflow?

See also:

third_party/py/rules_python_riscv64_lift_timeout.patch

Sherlockzhangjinge · 2025-10-28T03:31:34Z

Thanks for your help, but this is for master branch(2.21.0), whose rules_python is 1.6.0. but tf2.20.0 , tf2.19.1 and tf2.20.0 using rules_python0.39.0. they have totally different structures. I failed apply your patchs:rules_python_riscv64_pypi.patch

IgnotaYun · 2025-10-28T06:15:02Z

Thanks for your help, but this is for master branch(2.21.0), whose rules_python is 1.6.0. but tf2.20.0 , tf2.19.1 and tf2.20.0 using rules_python0.39.0. they have totally different structures. I failed apply your patchs:rules_python_riscv64_pypi.patch

Checkout https://github.com/infiWang/tensorflow/tree/v2.20.0-riscv64 . Btw, I don't think TF release branch accepts PR?

mihaimaruseac · 2025-10-28T16:13:49Z

I don't think TF release branch accepts PR?

We don't. All changes need to occur on main branch and then they'll be included in the releases.

mihaimaruseac

Tentatively approving, but I think this will need more reviewers

Sherlockzhangjinge · 2025-11-01T14:13:07Z

Have you meet "Traceback (most recent call last):
File "", line 1, in
File "/python/venv311/lib/python3.11/site-packages/tensorflow/init.py", line 49, in
from tensorflow._api.v2 import internal
File "/python/venv311/lib/python3.11/site-packages/tensorflow/_api/v2/internal/init.py", line 8, in
from tensorflow._api.v2.internal import autograph
File "/python/venv311/lib/python3.11/site-packages/tensorflow/_api/v2/internal/autograph/init.py", line 8, in
from tensorflow.python.autograph.core.ag_ctx import control_status_ctx # line: 34
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/python/venv311/lib/python3.11/site-packages/tensorflow/python/autograph/core/ag_ctx.py", line 21, in
from tensorflow.python.autograph.utils import ag_logging
File "/python/venv311/lib/python3.11/site-packages/tensorflow/python/autograph/utils/init.py", line 17, in
from tensorflow.python.autograph.utils.context_managers import control_dependency_on_returns
File "/python/venv311/lib/python3.11/site-packages/tensorflow/python/autograph/utils/context_managers.py", line 19, in
from tensorflow.python.framework import ops
File "/python/venv311/lib/python3.11/site-packages/tensorflow/python/framework/ops.py", line 49, in
from tensorflow.python.client import pywrap_tf_session
File "/python/venv311/lib/python3.11/site-packages/tensorflow/python/client/pywrap_tf_session.py", line 19, in
from tensorflow.python.client._pywrap_tf_session import *
ImportError: /python/venv311/lib/python3.11/site-packages/tensorflow/python/client/_pywrap_tf_session.so: undefined symbol: _ZN17pybind11_protobuf16GenericProtoCastEPN6google8protobuf7MessageEN8pybind1119return_value_policyENS4_6handleEb"
when you import tf after compiling and pip install on riscv64?

IgnotaYun · 2025-11-02T03:20:58Z

@Sherlockzhangjinge Please wrap the log in a code block and fold it.

Yes, but only with GCC for some reason. Use ./configure to set Clang and do a bazel clean --expunge before building.

Clang-17 and Clang-20 have been verified to be working; Clang-19 should also work; Clang-18 ICEed on my machine however.

A broken and a working example

Imported from GitHub PR tensorflow/tensorflow#102607 This commit fixes #102159 which prevented TensorFlow from compiling on RISC-V 64 due to missing codepath in the build system. RFC: Currently this patch overrides timeout of rules_python for all platforms which is obviously not ideal. How do we set pip package timeout here in Tensorflow? See also: - bazelbuild/bazel#25236 - bazelbuild/bazel#25699 - bazel-contrib/rules_python#3350 - #32812 - tensorflow/runtime#135 Copybara import of the project: -- 13b7db883e6ea0aa631490fb5f806c55ceea7cb5 by gns <[email protected]>: [XLA:CPU] Add support for riscv64 Co-authored-by: Levi Zim <[email protected]> -- a00c3a3ba94664798960cbc2fb0a6746fe0c3ac1 by gns <[email protected]>: Add missing llvm:: namespace qualifiers for DTensor Add the `llvm::` namespace prefix to `cast` and `isa` where it was missing in the DTensor MLIR code. -- febc5abc56ab302f5f39fe20176ed00c0c95cb7e by gns <[email protected]>: runtime: add missing stdint header Co-authored-by: Levi Zim <[email protected]> -- 6bf63fec56a6d961b06d932fe69b76eae89d8cb7 by gns <[email protected]>: Add riscv64 support patch for rules_python bazel-contrib/rules_python#3350 -- 68c44fa9613d5577f36c51a192c932795e13ed83 by gns <[email protected]>: tools: py: add riscv64 to pip and manylinux compilance test -- 3f2fe1e0256476449f64658219d997727c9cc534 by gns <[email protected]>: Lift timeout of rules_python for BFS wheels -- 252a9b7ad2336b7abbb94e269b4a976b45d5d6e7 by gns <[email protected]>: Revert llvm toolchain patch for riscv64 As already upstreamed. Co-authored-by: Levi Zim <[email protected]> -- 51047a86131e991ffea74fccb8f55e3521237a64 by gns <[email protected]>: Lift timeout for BFS wheels during pip init -- 3b8276420031969423c9a1f150341a0e41fa372e by gns <[email protected]>: Refresh `rules_python` riscv64 patch Co-authored-by: Levi Zim <[email protected]> Merging this change closes #102607 FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#102607 from infiWang:riscv64 3b8276420031969423c9a1f150341a0e41fa372e PiperOrigin-RevId: 825073762

Imported from GitHub PR tensorflow/tensorflow#102607 This commit fixes #102159 which prevented TensorFlow from compiling on RISC-V 64 due to missing codepath in the build system. RFC: Currently this patch overrides timeout of rules_python for all platforms which is obviously not ideal. How do we set pip package timeout here in Tensorflow? See also: - bazelbuild/bazel#25236 - bazelbuild/bazel#25699 - bazel-contrib/rules_python#3350 - #32812 - tensorflow/runtime#135 Copybara import of the project: -- 13b7db883e6ea0aa631490fb5f806c55ceea7cb5 by gns <[email protected]>: [XLA:CPU] Add support for riscv64 Co-authored-by: Levi Zim <[email protected]> -- a00c3a3ba94664798960cbc2fb0a6746fe0c3ac1 by gns <[email protected]>: Add missing llvm:: namespace qualifiers for DTensor Add the `llvm::` namespace prefix to `cast` and `isa` where it was missing in the DTensor MLIR code. -- febc5abc56ab302f5f39fe20176ed00c0c95cb7e by gns <[email protected]>: runtime: add missing stdint header Co-authored-by: Levi Zim <[email protected]> -- 6bf63fec56a6d961b06d932fe69b76eae89d8cb7 by gns <[email protected]>: Add riscv64 support patch for rules_python bazel-contrib/rules_python#3350 -- 68c44fa9613d5577f36c51a192c932795e13ed83 by gns <[email protected]>: tools: py: add riscv64 to pip and manylinux compilance test -- 3f2fe1e0256476449f64658219d997727c9cc534 by gns <[email protected]>: Lift timeout of rules_python for BFS wheels -- 252a9b7ad2336b7abbb94e269b4a976b45d5d6e7 by gns <[email protected]>: Revert llvm toolchain patch for riscv64 As already upstreamed. Co-authored-by: Levi Zim <[email protected]> -- 51047a86131e991ffea74fccb8f55e3521237a64 by gns <[email protected]>: Lift timeout for BFS wheels during pip init -- 3b8276420031969423c9a1f150341a0e41fa372e by gns <[email protected]>: Refresh `rules_python` riscv64 patch Co-authored-by: Levi Zim <[email protected]> Merging this change closes #102607 FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#102607 from infiWang:riscv64 3b8276420031969423c9a1f150341a0e41fa372e PiperOrigin-RevId: 836231774

mihaimaruseac

ERROR: Traceback (most recent call last):
	File ".../tensorflow/tools/pip_package/BUILD", line 443, column 33, in <toplevel>
		verify_manylinux_compliance_test(
	File "/root/.cache/bazel/_bazel_root/ea483706e4f40e2efb3464442bfeb24e/external/local_xla/third_party/py/py_manylinux_compliance_test.bzl", line 5, column 5, in verify_manylinux_compliance_test
		def verify_manylinux_compliance_test(
Error: verify_manylinux_compliance_test() got unexpected keyword argument: riscv64_compliance_tag (did you mean 'aarch64_compliance_tag'?)
ERROR: package contains errors: tensorflow/tools/pip_package
Loading: 683 packages loaded
    currently loading: tensorflow/lite ... (136 packages)
ERROR: package contains errors: tensorflow/tools/pip_package: Traceback (most recent call last):
	File ".../tensorflow/tools/pip_package/BUILD", line 443, column 33, in <toplevel>
		verify_manylinux_compliance_test(
	File "/root/.cache/bazel/_bazel_root/ea483706e4f40e2efb3464442bfeb24e/external/local_xla/third_party/py/py_manylinux_compliance_test.bzl", line 5, column 5, in verify_manylinux_compliance_test
		def verify_manylinux_compliance_test(
Error: verify_manylinux_compliance_test() got unexpected keyword argument: riscv64_compliance_tag (did you mean 'aarch64_compliance_tag'?)

Imported from GitHub PR tensorflow/tensorflow#102607 This commit fixes #102159 which prevented TensorFlow from compiling on RISC-V 64 due to missing codepath in the build system. RFC: Currently this patch overrides timeout of rules_python for all platforms which is obviously not ideal. How do we set pip package timeout here in Tensorflow? See also: - bazelbuild/bazel#25236 - bazelbuild/bazel#25699 - bazel-contrib/rules_python#3350 - #32812 - tensorflow/runtime#135 Copybara import of the project: -- 13b7db883e6ea0aa631490fb5f806c55ceea7cb5 by gns <[email protected]>: [XLA:CPU] Add support for riscv64 Co-authored-by: Levi Zim <[email protected]> -- a00c3a3ba94664798960cbc2fb0a6746fe0c3ac1 by gns <[email protected]>: Add missing llvm:: namespace qualifiers for DTensor Add the `llvm::` namespace prefix to `cast` and `isa` where it was missing in the DTensor MLIR code. -- febc5abc56ab302f5f39fe20176ed00c0c95cb7e by gns <[email protected]>: runtime: add missing stdint header Co-authored-by: Levi Zim <[email protected]> -- 6bf63fec56a6d961b06d932fe69b76eae89d8cb7 by gns <[email protected]>: Add riscv64 support patch for rules_python bazel-contrib/rules_python#3350 -- 68c44fa9613d5577f36c51a192c932795e13ed83 by gns <[email protected]>: tools: py: add riscv64 to pip and manylinux compilance test -- 3f2fe1e0256476449f64658219d997727c9cc534 by gns <[email protected]>: Lift timeout of rules_python for BFS wheels -- 252a9b7ad2336b7abbb94e269b4a976b45d5d6e7 by gns <[email protected]>: Revert llvm toolchain patch for riscv64 As already upstreamed. Co-authored-by: Levi Zim <[email protected]> -- 51047a86131e991ffea74fccb8f55e3521237a64 by gns <[email protected]>: Lift timeout for BFS wheels during pip init -- 3b8276420031969423c9a1f150341a0e41fa372e by gns <[email protected]>: Refresh `rules_python` riscv64 patch Co-authored-by: Levi Zim <[email protected]> Merging this change closes #102607 FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#102607 from infiWang:riscv64 3b8276420031969423c9a1f150341a0e41fa372e PiperOrigin-RevId: 836231774

keerthanakadiri · 2026-01-09T09:00:08Z

Hi @infiWang, Can you please reslove the conflicts? Thank you !

Co-authored-by: Levi Zim <[email protected]>

Add the `llvm::` namespace prefix to `cast` and `isa` where it was missing in the DTensor MLIR code.

Co-authored-by: Levi Zim <[email protected]>

bazel-contrib/rules_python#3350

As already upstreamed. Co-authored-by: Levi Zim <[email protected]>

Co-authored-by: Levi Zim <[email protected]>

IgnotaYun · 2026-01-09T09:20:07Z

Sorry for missing here, busy with other projects.

Hi @infiWang, Can you please reslove the conflicts? Thank you !

Rebased and resolved. Sorry for the inconvenience.

ERROR: Traceback (most recent call last):
	File ".../tensorflow/tools/pip_package/BUILD", line 443, column 33, in <toplevel>
		verify_manylinux_compliance_test(
	File "/root/.cache/bazel/_bazel_root/ea483706e4f40e2efb3464442bfeb24e/external/local_xla/third_party/py/py_manylinux_compliance_test.bzl", line 5, column 5, in verify_manylinux_compliance_test
		def verify_manylinux_compliance_test(
Error: verify_manylinux_compliance_test() got unexpected keyword argument: riscv64_compliance_tag (did you mean 'aarch64_compliance_tag'?)
ERROR: package contains errors: tensorflow/tools/pip_package
Loading: 683 packages loaded
    currently loading: tensorflow/lite ... (136 packages)
ERROR: package contains errors: tensorflow/tools/pip_package: Traceback (most recent call last):
	File ".../tensorflow/tools/pip_package/BUILD", line 443, column 33, in <toplevel>
		verify_manylinux_compliance_test(
	File "/root/.cache/bazel/_bazel_root/ea483706e4f40e2efb3464442bfeb24e/external/local_xla/third_party/py/py_manylinux_compliance_test.bzl", line 5, column 5, in verify_manylinux_compliance_test
		def verify_manylinux_compliance_test(
Error: verify_manylinux_compliance_test() got unexpected keyword argument: riscv64_compliance_tag (did you mean 'aarch64_compliance_tag'?)

Sorry, but how do you reproduce this?

mihaimaruseac · 2026-01-09T17:32:50Z

bazel build //tensorflow:tensorflow/tools/pip_package or something like that

IgnotaYun · 2026-01-12T10:33:22Z

Hmm, I can't reproduce that on my side🤔

mihaimaruseac · 2026-01-12T14:59:43Z

What is the bazel version you are using?

IgnotaYun · 2026-01-12T15:06:09Z

Bazel 7.6.1 w/ back ported support for RISC-V, https://github.com/infiWang/bazel/tree/release-7.6.1-riscv64

mihaimaruseac · 2026-01-12T15:08:11Z

Oh, we're probably missing that backport.

google-ml-butler bot added the size:L CL Change Size: Large label Oct 20, 2025

google-ml-butler bot assigned gbaned Oct 20, 2025

keerthanakadiri requested a review from mihaimaruseac October 20, 2025 17:38

google-ml-butler bot added the awaiting review Pull request awaiting review label Oct 20, 2025

keerthanakadiri added this to PR Queue Oct 20, 2025

github-project-automation bot moved this to Assigned Reviewer in PR Queue Oct 20, 2025

mihaimaruseac suggested changes Oct 20, 2025

View reviewed changes

third_party/py/rules_python_riscv64_lift_timeout.patch Outdated Show resolved Hide resolved

github-project-automation bot moved this from Assigned Reviewer to Reviewer Requested Changes in PR Queue Oct 20, 2025

IgnotaYun force-pushed the riscv64 branch 2 times, most recently from 079c8e9 to 0ebb5ee Compare October 20, 2025 18:18

mihaimaruseac previously approved these changes Oct 28, 2025

View reviewed changes

google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 28, 2025

github-project-automation bot moved this from Reviewer Requested Changes to Approved by Reviewer in PR Queue Oct 28, 2025

kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 28, 2025

IgnotaYun dismissed mihaimaruseac’s stale review via a55aac2 October 29, 2025 04:03

IgnotaYun force-pushed the riscv64 branch from 0ebb5ee to a55aac2 Compare October 29, 2025 04:03

google-ml-butler bot removed the ready to pull PR ready for merge process label Oct 29, 2025

IgnotaYun force-pushed the riscv64 branch from a55aac2 to 51047a8 Compare October 29, 2025 04:06

IgnotaYun requested a review from mihaimaruseac October 29, 2025 04:07

mihaimaruseac approved these changes Oct 29, 2025

View reviewed changes

google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 29, 2025

kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 29, 2025

mihaimaruseac suggested changes Dec 2, 2025

View reviewed changes

github-project-automation bot moved this from Approved by Reviewer to Reviewer Requested Changes in PR Queue Dec 2, 2025

IgnotaYun and others added 9 commits January 9, 2026 17:13

[XLA:CPU] Add support for riscv64

3c7a007

Co-authored-by: Levi Zim <[email protected]>

Add missing llvm:: namespace qualifiers for DTensor

8a90c13

Add the `llvm::` namespace prefix to `cast` and `isa` where it was missing in the DTensor MLIR code.

runtime: add missing stdint header

f365dba

Co-authored-by: Levi Zim <[email protected]>

Add riscv64 support patch for rules_python

a847cbf

bazel-contrib/rules_python#3350

tools: py: add riscv64 to pip and manylinux compilance test

8f7d4d0

Lift timeout of rules_python for BFS wheels

cd7c519

Revert llvm toolchain patch for riscv64

b60e92a

As already upstreamed. Co-authored-by: Levi Zim <[email protected]>

Lift timeout for BFS wheels during pip init

8fb9c28

Refresh rules_python riscv64 patch

4d8f5b4

Co-authored-by: Levi Zim <[email protected]>

IgnotaYun force-pushed the riscv64 branch from 3b82764 to 4d8f5b4 Compare January 9, 2026 09:17

google-ml-butler bot removed the ready to pull PR ready for merge process label Jan 9, 2026

keerthanakadiri requested a review from cantonios February 24, 2026 06:18

google-ml-butler bot added the awaiting review Pull request awaiting review label Feb 24, 2026

keerthanakadiri added stat:awaiting response Status - Awaiting response from author and removed awaiting review Pull request awaiting review labels Feb 25, 2026

Conversation

IgnotaYun commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Sherlockzhangjinge commented Oct 28, 2025

Uh oh!

IgnotaYun commented Oct 28, 2025

Uh oh!

mihaimaruseac commented Oct 28, 2025

Uh oh!

mihaimaruseac left a comment

Choose a reason for hiding this comment

Uh oh!

Sherlockzhangjinge commented Nov 1, 2025

Uh oh!

IgnotaYun commented Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mihaimaruseac left a comment

Choose a reason for hiding this comment

Uh oh!

keerthanakadiri commented Jan 9, 2026

Uh oh!

IgnotaYun commented Jan 9, 2026

Uh oh!

mihaimaruseac commented Jan 9, 2026

Uh oh!

IgnotaYun commented Jan 12, 2026

Uh oh!

mihaimaruseac commented Jan 12, 2026

Uh oh!

IgnotaYun commented Jan 12, 2026

Uh oh!

mihaimaruseac commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

IgnotaYun commented Oct 20, 2025 •

edited

Loading

IgnotaYun commented Nov 2, 2025 •

edited

Loading