Skip to content

Commit 60d5bfb

Browse files
Add upper bound to protobuf in setup.py.
See also: #53234 See also: protocolbuffers/protobuf#9954 See also: #56077 PiperOrigin-RevId: 450054200
1 parent 7806ae5 commit 60d5bfb

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

‎tensorflow/tools/pip_package/setup.py‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,14 @@ def standard_or_nightly(standard, nightly):
8787
'numpy >= 1.20',
8888
'opt_einsum >= 2.3.2',
8989
'packaging',
90-
'protobuf >= 3.9.2',
90+
# TODO(b/182876485): Protobuf 3.20 results in linker errors on Windows
91+
# Protobuf 4.0 is binary incompatible with what C++ TF uses.
92+
# We need ~1 quarter to update properly.
93+
# See also: https://github.com/tensorflow/tensorflow/issues/53234
94+
# See also: https://github.com/protocolbuffers/protobuf/issues/9954
95+
# See also: https://github.com/tensorflow/tensorflow/issues/56077
96+
# This is a temporary patch for now, to patch previous TF releases.
97+
'protobuf >= 3.9.2, < 3.20',
9198
'setuptools',
9299
'six >= 1.12.0',
93100
'termcolor >= 1.1.0',

0 commit comments

Comments
 (0)