Skip to content

deeplab/local_test.sh: Use 'bash' instead of 'sh' #8534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
YknZhu merged 1 commit into from
Jul 16, 2020
Merged

deeplab/local_test.sh: Use 'bash' instead of 'sh' #8534

YknZhu merged 1 commit into from
Jul 16, 2020

Conversation

@ruslo
Copy link
Contributor

@ruslo ruslo commented May 19, 2020 •
edited
Loading

Description

Use 'bash' instead of 'sh' in deeplab/local_test.sh:

  • Make it consistent with '/bin/bash' shebang
  • Fix "Bad substitution" error in BASH_SOURCE[0]

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Tests

[research/deeplab]> bash local_test.sh

Test Configuration:

  • Tensorflow 1.15.2
  • Ubuntu 18.04.4 LTS
  • CUDA 10.1

Checklist

@ruslo
deeplab/local_test.sh: Use 'bash' instead of 'sh'
534c3f5 
- Make it consistent with '/bin/bash' shebang
- Fix "Bad substitution" error in BASH_SOURCE[0]
@ruslo ruslo requested review from YknZhu and aquariusjay as code owners May 19, 2020 05:15
@ruslo ruslo mentioned this pull request Jul 14, 2020
Merged
9 tasks
@ruslo
Copy link
Contributor Author

ruslo commented Jul 16, 2020

@aquariusjay Let me know if there are any problems with this one

@YknZhu YknZhu merged commit 5f9bfd8 into tensorflow:master Jul 16, 2020
@YknZhu
Copy link
Contributor

YknZhu commented Jul 16, 2020

Thanks Ruslan!

@ruslo ruslo deleted the pr.bash branch July 16, 2020 17:23
kmindspark pushed a commit to kmindspark/models that referenced this pull request Jul 19, 2020
@ruslo @kmindspark
deeplab/local_test.sh: Use 'bash' instead of 'sh' (tensorflow#8534)
db75e41 
- Make it consistent with '/bin/bash' shebang
- Fix "Bad substitution" error in BASH_SOURCE[0]
kmindspark pushed a commit to kmindspark/models that referenced this pull request Jul 23, 2020
@ruslo @kmindspark
deeplab/local_test.sh: Use 'bash' instead of 'sh' (tensorflow#8534)
54fe0c4 
- Make it consistent with '/bin/bash' shebang
- Fix "Bad substitution" error in BASH_SOURCE[0]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aquariusjay aquariusjay Awaiting requested review from aquariusjay

1 more reviewer

@YknZhu YknZhu YknZhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@YknZhu YknZhu

@aquariusjay aquariusjay

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ruslo @YknZhu @googlebot @aquariusjay