feat: check quals to skip rerank if rerank_in_table is enabled
#206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a feature to check qualifiers and skip reranking when the “rerank_in_table” option is enabled. It includes new hook functionality for rewriting the plan state, refactoring of the operator family into an enum with updated helper functions, and modifications across the scanners, datum unboxing, pointer conversion, and algorithm modules to support the new logic.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/index/hook.rs | Added rewrite_plan_state and executor_start hooks to conditionally skip rerank based on qualifiers. |
| src/index/scanners/mod.rs | Introduced DefaultBuilder and updated search builder traits to support new scan behavior. |
| src/index/scanners/default.rs | Updated SearchBuilder implementation for handling vector and sphere inputs. |
| src/datatype/memory_halfvec.rs | Added UnboxDatum implementation for HalfvecInput. |
| src/datatype/memory_vector.rs | Added UnboxDatum implementation for VectorInput. |
| src/index/opclass.rs | Refactored Opfamily from a struct to an enum with corresponding function updates. |
| src/index/am/mod.rs | Revised scan hooks and pointer conversion functions to align with new design. |
| src/index/algorithm.rs | Updated operator-dependent functions (prewarm, bulkdelete, maintain, insert) accordingly. |
| src/index/am/am_build.rs | Adjusted traverse and build functions for better integration with the new store design. |
| src/lib.rs | Enabled the “lazy_get” feature. |
| src/index/projection.rs | Removed deprecated trait implementations. |
| src/index/functions.rs | Simplified prewarm function implementation to call the updated algorithm function. |
| crates/algorithm/src/rerank.rs | Changed the fetch function parameter to mutable for better iteration behavior. |
Comments suppressed due to low confidence (1)
src/index/hook.rs:41
- [nitpick] The field name 'hack' is ambiguous and may be misleading in production code. Consider renaming it to something more descriptive, such as 'qual_context' or 'scan_state_ptr', to clarify its purpose.
scanner.hack = std::ptr::NonNull::new(node);
usamoi
force-pushed
the
hook
branch
2 times, most recently
from
48de903 to
8df84be
Compare
Signed-off-by: usamoi <[email protected]>
Signed-off-by: usamoi <[email protected]>
Signed-off-by: usamoi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #205