fix(spothub): switch mode on Spot List double-click (#2298)#2372
Merged
fix(spothub): switch mode on Spot List double-click (#2298)#2372
Conversation
Double-clicking a row in the SpotHub Spot List previously only updated slice frequency, leaving the receiver in its prior mode. Panadapter spot-label clicks already auto-switched mode, but the Spot List bypassed that path. Extract the spot-mode → radio-mode logic from MainWindow into a SpotModeResolver helper (explicit mode → comment parse → band-plan inference → radio mode mapping) and call it from both click paths so they stay in sync. Honors the existing SpotAutoSwitchMode setting. Co-Authored-By: Claude Opus 4.7 <[email protected]>
aethersdr-agent
Bot
requested review from
AetherClaude,
jensenpat and
ten9876
as code owners
2 tasks
The double-click handler in this PR replaced its only consumer with spotAt(row)->freqMhz, leaving freqAtRow declared and defined but never called. Drop it. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Owner
|
Claude here on Jeremy's behalf — merged via admin squash. Folded in a small cleanup (dropped now-unused 73, Jeremy KK7GWY & Claude (AI dev partner) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2298. Double-clicking a row in the SpotHub Spot List previously only updated the slice frequency, leaving the receiver in its prior mode (e.g. SSB on 7 MHz → click a CW spot → frequency moves but mode stays SSB). Panadapter spot-label clicks already auto-switched mode, but the Spot List bypassed that path.
SpotModeResolverhelper (explicit mode → comment first/last word → band-plan inference → radio-mode mapping).DxClusterDialog::tuneRequestedto carry the spot's parsed mode and raw comment, and addedSpotTableModel::spotAt()so the slot has access to the underlyingDxSpot.SpotAutoSwitchModesetting; the panadapter path keeps its FreeDV → RADE special case.spot_mode_resolver_testcovering comment parsing, band-plan inference, mode mapping, and the issue-2298 motivating cases.Test plan
cmake --build build --target aethersdrsucceeds.ctest -R spot_mode_resolver_testpasses.SpotAutoSwitchMode=True, on 7 MHz SSB, double-click a CW spot in the SpotHub Spot List → slice retunes and switches to CW.SpotAutoSwitchMode=False, double-click does not change the mode.Generated by AetherClaude (automated agent for AetherSDR)