Conversation
Owner
ten9876
commented
May 3, 2026
- Spectrum overlay menu: remove DSP sub-panel
- Minimal mode + title bar drag: collapse exit paths, fix gutter drag
- Spectrum overlay menu: remove DSP sub-panel - Minimal mode + title bar drag: collapse exit paths, fix gutter drag
This was referenced May 5, 2026
ten9876
pushed a commit
that referenced
this pull request
May 5, 2026
…#2367) On macOS, AppKit delivers Qt::WindowStateChange asynchronously, so the Maximized/FullScreen bit could survive setFixedWidth(260) inside toggleMinimalMode(true). The deferred WindowStateChange then arrived with m_minimalMode==true and the Maximized bit still set, causing changeEvent to schedule a spurious toggleMinimalMode(false) — the window collapsed for a frame and snapped back to the full-size geometry restored from FullModeGeometry. - toggleMinimalMode(true): drop maximized/fullscreen state via showNormal() before forcing the applet width. FullModeGeometry is saved first, so exit can still restore the user's pre-minimal window. - Add m_enteringMinimalMode guard symmetric to m_exitingMinimalMode and honor it in changeEvent. Cleared via singleShot(0) so any AppKit- deferred WindowStateChange queued during the enter path drains through the early-return before the guard drops. Both behaviors are no-ops on Windows/Linux where setFixedWidth on a maximized top-level synchronously clears the state bit. Regressed in #2299, which collapsed minimal-exit paths into the single changeEvent branch and exposed the missing entering-side guard. Co-authored-by: AetherClaude <[email protected]> Co-authored-by: Claude Opus 4.7 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.