Conversation
- Aetherial Audio: decouple TX applet visibility from bypass + dim on bypass - Aetherial Noise Reduction: docked RX-side DSP applet + chain DSP toggle - Aetherial Noise Reduction: NR4 polish, platform guards, wisdom-aware NR2 enable - VFO DSP grid: drop client-side buttons, add shared level slider - Spectrum overlay menu: remove DSP sub-panel
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates client-side DSP from three surfaces (VFO DSP grid,
spectrum overlay sub-panel, AetherDSP dialog) down to one: a new
docked Aetherial Noise Reduction applet on the PooDoo RX side,
which the Settings-menu dialog also embeds via shared
`AetherDspWidget`. Radio-side DSP now lives only on `VfoWidget`.
Changes
reusable widget with compact-mode support; both `AetherDspDialog`
and the new `ClientRxDspApplet` embed it. Single source of truth
for AppSettings persistence.
exclusive DSP selector (NR2 / NR4 / MNR / DFNR / RN2 / BNR) +
per-DSP control pages in a stacked widget. Single-click on the RX
chain DSP tile bypasses; double-click opens the full editor.
shared DSP-level slider with a push/pop activation stack so the
slider tracks the most-recently-enabled radio DSP and hides
cleanly when no slider-bearing DSP is active.
Drops 11 toggle/right-click signals, six button accessors, the
15-row `DspRow` grid, and the build/sync/toggle triplet.
state; bypassed applets dim instead of disappearing (matches
Aetherial TX EQ).
`MainWindow::enableNr2WithWisdom()` for both the applet and the
RX chain widget, fixing the NR4→NR2 transition crash caused by
FFTW wisdom version mismatch (Avoid NR2 wisdom generation on audio thread #2275).
panels, undo/reset icon repositioning, padding fixes.
guarded by `HAVE_BNR`.
Test plan
applets, no double-display of TX+RX
re-enables the last-selected DSP
`AetherDspDialog`
switches the engine DSP and the visible parameter page
DSPs, hides when last one disabled, falls back to next active
DSP if multiple are enabled
applet)
🤖 Generated with Claude Code