Sweep: 7 small UI / contrast / indicator-routing fixes#2270
Merged
Conversation
Bundles seven independently-verified maintainer-reviewed fixes: - #2027 TitleBar headline now shows running version number — regressed with frameless-window mode (#1926). Restored via the same applicationVersion() pattern used by setWindowTitle(). - #2263 FlexControl knob press tokens are bare S/C/L (not X4S/X4C/X4L). Verified against hardware capture from LB2EG: side buttons emit X1S/X1C/X1L/X2S/.../X3L (parsed correctly today), knob press emits bare S/C/L. Adds a new branch in processCommand() mapping the bare tokens to buttonPressed(4, action), keeping the X-prefix path for the side buttons. Dead X4S path retained as defense in depth. - #2264 ggmorse Å sequence corrected from 01110 to 01101 per ITU-R M.1677-1. Confirmed Æ (0101) and Ø (1110) on the same lines are unaffected. - #1564 K/SFI/WNB/RF Gain/WIDE indicator strip click suppression. New m_indicatorStripRect tracks the full strip in both paint paths; mouseReleaseEvent guards skip the frequency emit when single-click tune lands inside the strip. Existing m_propClickRect dialog click is unaffected. - #1576 Slice record (⏺) and play (▶) button visibility. Roughly doubled alpha values across all four stylesheet locations and brightened the inactive icon colors so the buttons are legible against the #0a0a14 spectrum background. - #1581 + the close (✕) and lock (🔓) buttons on each slice header now share a single sliceBtnStyle base with record/play, ensuring identical 20px circles. Status indicators (TNF/CWX/DVK/FDX) all use cyan #00b4d8 for active and #404858 for off; TNF init colour fixed (was rgba(255,255,255,128)). updateKeyerAvailability() and the CWX/DVK click handlers now use #404858 instead of rgba(255,255,255,40) for the off-state, so DVK in voice mode matches the rest of the indicator strip when not in use. - #1583 Status-bar time stack reduced from 3 rows to 2 (date + UTC time) by removing the grid-square label, matching every other telemetry stack. m_gridLabel removed from MainWindow.h. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
ten9876
deleted the
auto/Sweep-7-small-UI--contrast--indicator-routing-fixe
branch
This was referenced May 2, 2026
ten9876
added a commit
that referenced
this pull request
May 2, 2026
Reliability sweep release. Headline is jensenpat's DAX2 coexistence policy refactor (#2271): platform-aware decision table, lazy dax_tx stream creation, anti-stomp on incoming foreign DAX TX status, LAN VITA UDP rebind on Flex's "Port/IP pair already in use" error, dead- orphan DAX RX detection, and 24+ test assertions. Substantial reliability fixes around disconnect teardown (#2247 — sequenced stream remove with response wait, dropped self-disconnect, dying-gasp byte), worker-thread shutdown (#2248 — no more killTimer warnings), and panadapter zoom (#2246 — no spectrum flash). Closes 12 issues via two paired triage-cleanup sweep PRs (#2270 + #2272) covering small UI bugs, contrast, indicator routing, click-to- tune behaviour, and visible regressions from recent feature work. Also includes the #2273 follow-up to #2271: setDax() and DAX TX stream creation are now both gated on platforms that can actually feed DAX audio, so Linux non-PipeWire builds keep digital TX on the physical mic input rather than going silent. Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundles seven independently-verified maintainer-reviewed fixes:
Show Running Version Number in Headline #315 #2027 TitleBar headline now shows running version number — regressed
with frameless-window mode (Frameless main window with title-bar drag, min/max/close, and size grip #1926). Restored via the same
applicationVersion() pattern used by setWindowTitle().
FlexControl knob-click tokens incorrect (X4S/X4C/X4L → S/C/L) — clicks have no effect #2263 FlexControl knob press tokens are bare S/C/L (not X4S/X4C/X4L).
Verified against hardware capture from LB2EG: side buttons emit
X1S/X1C/X1L/X2S/.../X3L (parsed correctly today), knob press emits
bare S/C/L. Adds a new branch in processCommand() mapping the bare
tokens to buttonPressed(4, action), keeping the X-prefix path for
the side buttons. Dead X4S path retained as defense in depth.
ggmorse.cpp line 87: Å Morse sequence incorrect (01110 → 01101) per ITU-R M.1677-1 #2264 ggmorse Å sequence corrected from 01110 to 01101 per
ITU-R M.1677-1. Confirmed Æ (0101) and Ø (1110) on the same lines
are unaffected.
disable single-click on K SFI WNB panel #1564 K/SFI/WNB/RF Gain/WIDE indicator strip click suppression. New
m_indicatorStripRect tracks the full strip in both paint paths;
mouseReleaseEvent guards skip the frequency emit when single-click
tune lands inside the strip. Existing m_propClickRect dialog click
is unaffected.
Low contrast/visibility for Slice Recording and Playback indicators in Dark Theme #1576 Slice record (⏺) and play (▶) button visibility. Roughly
doubled alpha values across all four stylesheet locations and
brightened the inactive icon colors so the buttons are legible
against the #0a0a14 spectrum background.
Status indicators (TNF, CWX, DVK, FDX) lack functional color-coding in Dark Theme #1581 + the close (✕) and lock (🔓) buttons on each slice header
now share a single sliceBtnStyle base with record/play, ensuring
identical 20px circles. Status indicators (TNF/CWX/DVK/FDX) all
use cyan #00b4d8 for active and #404858 for off; TNF init colour
fixed (was rgba(255,255,255,128)). updateKeyerAvailability() and
the CWX/DVK click handlers now use #404858 instead of
rgba(255,255,255,40) for the off-state, so DVK in voice mode
matches the rest of the indicator strip when not in use.
Date/Time status indicator font size and alignment inconsistency #1583 Status-bar time stack reduced from 3 rows to 2 (date + UTC
time) by removing the grid-square label, matching every other
telemetry stack. m_gridLabel removed from MainWindow.h.
Co-Authored-By: Claude Opus 4.7 (1M context) [email protected]