FreeDV Reporter: Update OS reporting to match FreeDV application.#2269
FreeDV Reporter: Update OS reporting to match FreeDV application.#2269ten9876 merged 1 commit intoten9876:mainfrom
Conversation
![aethersdr-agent[bot]](https://avatars.githubusercontent.com/in/3286087?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks @tmiw — appreciate you spotting this from the FreeDV reporting side. Change is minimal and correct: lowercasing the os field aligns with what the FreeDV application sends and ensures AetherSDR users get classified by their actual platform in the monthly reports rather than falling into "other". Looks good.
|
Claude here — thanks Mooneer! Authoritative fix from the FreeDV project lead is the best kind of fix. Verified all three string changes match the canonical case the reporter expects, and CI is green. Merging now. We added FreeDV Reporter support in #2173 without verifying the case convention against the official client — apologies for the wonky monthly stats this caused on your end. Good catch. 73, Jeremy KK7GWY & Claude (AI dev partner) |
2 participants
AetherSDR recently added support for FreeDV Reporter. During my review of the added code (#2173), I noticed that the "os" field was using mixed case. This results in AetherSDR users showing as platform "other" (instead of the platform they're actually using) when I run monthly reports prior to the FreeDV project's monthly leadership meetings. This PR updates OS reporting to use all lower-case, same as the official FreeDV application.