fix(ui): add dark-mode stylesheet to FreeDV Reporter checkboxes#2268
fix(ui): add dark-mode stylesheet to FreeDV Reporter checkboxes#2268ten9876 merged 2 commits intoten9876:mainfrom
Conversation
The three QCheckBox widgets in the Station Reporting tab (enable reporting, use radio callsign, use GPS) had no indicator styling, making their outlines invisible against the dark theme background. Apply the standard dark-mode indicator style (matching ConnectionPanel and other dialogs) to all three: visible #5d748d border, hover highlight, checked fill, and disabled state. Fixes ten9876#2213 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
![aethersdr-agent[bot]](https://avatars.githubusercontent.com/in/3286087?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks @NF0T — fix looks correct and the indicator colors match the existing ConnectionPanel dark-mode convention (#5d748d border, #2f71b6/#8cc8ff checked, etc.). Scope is narrow and stays inside buildFreeDvTab(), no convention or RAII concerns.
One small suggestion (non-blocking): the same 6-line stylesheet is duplicated verbatim three times. This file already has the pattern of hoisting it to a local — see QString cbStyle = ... at src/gui/DxClusterDialog.cpp:1088 and src/gui/DxClusterDialog.cpp:1780. Something like:
const QString fdvCheckStyle =
"QCheckBox { color: #d7e4f2; spacing: 8px; background: transparent; border: none; }"
"QCheckBox::indicator { width: 14px; height: 14px; border: 2px solid #5d748d; border-radius: 3px; background: #0b1520; }"
"QCheckBox::indicator:hover { border-color: #81abd9; background: #142130; }"
"QCheckBox::indicator:checked { border: 2px solid #8cc8ff; background: #2f71b6; }"
"QCheckBox::indicator:disabled { border-color: #405262; background: #10161d; }";declared once at the top of the Station Reporting section and applied via setStyleSheet(fdvCheckStyle) to all three checkboxes would keep the three indicators in lockstep if anyone tweaks the palette later. Not a merge blocker — happy either way.
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
Applied the suggestion — stylesheet hoisted to a single |
|
Claude here — thanks Ryan! Clean fix, follows the established Merging as a partial fix for #2213 — your change resolves the visibility aspect (the checkboxes were genuinely invisible against the dark background, which likely explains why the original reporter thought reporting was off). The two underlying functional complaints in #2213 — outbound spots not actually being sent in RADE mode, and Auto Start not persisting across app restarts — remain to be addressed separately. Will leave #2213 open and post a note there pointing to your contribution. 73, Jeremy KK7GWY & Claude (AI dev partner) |
2 participants
Summary
QCheckBoxwidgets in the FreeDV tab → Station Reporting group (enable reporting, use radio callsign, use GPS) had no indicator stylesheet, making their outlines invisible in dark modeConnectionPaneland other dialogs):#5d748dborder, hover highlight, checked fill#2f71b6/#8cc8ff, and disabled stateFixes #2213
Test plan
🤖 Generated with Claude Code