Skip to content

Refresh radio model label when info arrives#2244

Merged
ten9876 merged 1 commit intoten9876:mainfrom
rfoust:codex/fix-radio-model-status
May 1, 2026
Merged

Refresh radio model label when info arrives#2244
ten9876 merged 1 commit intoten9876:mainfrom
rfoust:codex/fix-radio-model-status

Conversation

@rfoust
Copy link
Copy Markdown
Contributor

@rfoust rfoust commented May 1, 2026

Summary

Fixes a status bar bug where the radio model number could be missing above the version number after connecting.

onConnectionStateChanged() populates the status bar immediately, but radio info such as model can arrive later through RadioModel::infoChanged. The version label already refreshed on infoChanged; this change refreshes the model label on the same signal when a non-empty model is available.

Testing

  • Configured with CMake/Ninja in /private/tmp/aethersdr-build-radio-model-status
  • Built successfully with cmake --build /private/tmp/aethersdr-build-radio-model-status
  • Confirmed the radio model appears above the version number when launching the built app

Copilot AI review requested due to automatic review settings May 1, 2026 12:43
@rfoust rfoust requested a review from ten9876 as a code owner May 1, 2026 12:43
Copilot AI reviewed May 1, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the MainWindow status bar to ensure the connected radio’s model label refreshes when radio info arrives asynchronously after the initial connection UI update.

Changes:

  • Refresh the radio model label on RadioModel::infoChanged when a non-empty model becomes available.
  • Update the related inline comment to reflect that multiple labels can be refreshed on late-arriving radio info.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aethersdr-agent
Copy link
Copy Markdown
Contributor

aethersdr-agent Bot commented May 1, 2026

CI failure analysis for fe35f09

The red check here is not caused by your code — it's a CI infrastructure issue.

What failed: The Cleanup artifacts job failed at the Delete artifacts step. This is a post-pipeline housekeeping task that removes temporary build artifacts after the real work is done. It has nothing to do with your changes in src/gui/MainWindow.cpp.

Your actual build status:

  • build — still in progress
  • analyze (cpp) — still in progress
  • Prepare, Agent, Upload results, check-paths — all passed

What to do: Nothing on your end — this is a transient GitHub Actions issue (likely a permissions/API rate-limit hiccup when the workflow tried to delete artifacts via gh api). A maintainer can re-run the failed job, or it can be ignored since it doesn't affect build correctness.

Your diff looks clean — just wiring m_radioInfoLabel to update from RadioModel::infoChanged, which is consistent with the existing pattern for m_radioVersionLabel right below it. Nice fix!

Automated analysis by aethersdr-agent

ten9876
ten9876 approved these changes May 1, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@ten9876 ten9876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial +3/-1, mirrors existing pattern exactly. Approving.

@ten9876 ten9876 merged commit edc7a57 into ten9876:main May 1, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ten9876 ten9876 ten9876 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rfoust @ten9876