Read radio-side SWR meter when sweeping through TGXL bypass#2230
Merged
Read radio-side SWR meter when sweeping through TGXL bypass#2230
Conversation
Closes #2229. The SWR sweep aborted with "no fresh TGXL SWR meter data" whenever the user had a TGXL in OPERATE mode at sweep start. Pre-sweep logic selected `meterSource = Tgxl`, then commanded the TGXL into BYPASS to measure raw antenna SWR. Once in bypass the TGXL is a passive wire-through; its measurement engine stops emitting `RL` (return-loss → SWR) meter packets, so `tgxlSwrUpdatedAtMs()` never advances past `sampleNotBeforeMs` and the per-step freshness check times out at 900 ms. While the TGXL is bypassed the radio's own SWR coupler sees the same physical signal — the radio measures directly through the bypassed TGXL relays. The reading is equivalent and arrives reliably during the tune carrier. Switch the meter source to Radio for the duration of the sweep; keep the "TGXL BYPASS" UI label so users still see what configuration is in use. Tested on FLEX-8600 with TGXL in OPERATE — sweep now runs to completion and the TGXL is restored to OPERATE after the sweep ends. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2229
Problem
SWR sweep aborts with
SWR sweep stopped: no fresh TGXL SWR meter datawhenever the user has a TGXL in OPERATE mode at sweep start.The pre-sweep logic at MainWindow.cpp:10854-10856 selects
meterSource = Tgxl, then commands the TGXL into BYPASS to measure raw antenna SWR. Once in bypass the TGXL is a passive wire-through — its measurement engine stops emittingRL(return-loss → SWR) meter packets, sotgxlSwrUpdatedAtMs()never advances pastsampleNotBeforeMsand the per-step freshness check times out at 900 ms.Fix
While the TGXL is bypassed, the radio's own SWR coupler sees the same physical signal — the radio measures directly through the bypassed TGXL relays. The reading is equivalent and arrives reliably during the tune carrier.
Switch the meter source to
Radiowhile keeping the"TGXL BYPASS"UI label so users still see what configuration is in use.Test plan
Follow-up
The
SwrSweepMeterSource::Tgxlbranch is now effectively dead — no operating mode prefers TGXL meters over radio meters during a sweep (TGXL OPERATE during sweep would defeat the raw-antenna-SWR purpose; BYPASS makes the radio reading equivalent and more reliable). Could be removed in a follow-up cleanup PR.cc @jensenpat — small fix on top of your AetherSweep work.
🤖 Generated with Claude Code