SpectrumWidget: blank waterfall rows for 400ms after TX→RX (#2117)#2182
Merged
SpectrumWidget: blank waterfall rows for 400ms after TX→RX (#2117)#2182
Conversation
Issue #2117: after TX a bright transient stripe appears in the waterfall as the receiver AGC settles. Visible on FLEX-8600 + Windows 11 in particular. Adds an `m_txEndMs` timestamp set on TX→RX in setTransmitting(false). Both the FFT-derived (updateSpectrum) and native-tile (updateWaterfallRow) push paths check whether < 400 ms has elapsed since that transition, and skip the row if so. After 400 ms passes the timestamp is cleared so subsequent rows fall through normally. Also resets m_wfBlankerRingCount = 0 so the blanker baseline doesn't accumulate stale TX-time samples. Carved out of PR #2118 (bot, no maintainerCanModify) which conflicted with #2171's already-landed changes to the same setTransmitting(false) block. This commit re-applies cleanly on top of #2171, keeping both fixes (the FFT-fallback flag reset AND the post-TX blanking). Fixes #2117. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a 400 ms blanking window after TX→RX so the receiver AGC's settling transient doesn't paint a bright stripe across the waterfall (issue #2117).
Provenance
Carve-out of PR #2118 (authored by AetherClaude bot, `maintainerCanModify: false`). The bot's PR conflicted on rebase because it also touched the `setTransmitting(false)` block that PR #2171 landed earlier today. Both fixes belong in that block:
This branch re-applies just the #2117 logic on top of current main, preserving both fixes.
Implementation
Test plan
🤖 Generated with Claude Code