VfoWidget: clear orphaned Slice<N>_MarkerThin key after migration#2156
Merged
ten9876 merged 1 commit intoten9876:mainfrom Apr 30, 2026
Merged
VfoWidget: clear orphaned Slice<N>_MarkerThin key after migration#2156ten9876 merged 1 commit intoten9876:mainfrom
ten9876 merged 1 commit intoten9876:mainfrom
Conversation
Resolves ten9876#2143. ten9876#2141 migrated per-slice marker-style preferences from `Slice<N>_MarkerThin` (bool) to `Slice<N>_MarkerWidth` (int 0/1/3). `loadDisplayPrefs()` reads the old key only as a fallback when the new key is absent, but never deletes it -- so the orphan accumulates in `~/.config/AetherSDR/AetherSDR.settings` indefinitely. After migrating the value into `m_markerWidth`, remove the old key so subsequent `saveDisplayPrefs()` calls don't carry the orphan forward. The remove only fires once per slice (the next load will already see `keyW` and skip the else branch entirely), so this is a one-time cleanup per setting file. Tiny single-file fix as flagged in the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2143.
#2141 migrated per-slice marker-style preferences from
Slice<N>_MarkerThin(bool) toSlice<N>_MarkerWidth(int 0/1/3).loadDisplayPrefs()reads the old key only as a fallback when the new key is absent, but never deletes it — so the orphan accumulates in~/.config/AetherSDR/AetherSDR.settingsindefinitely.Change
After migrating the value into
m_markerWidth, remove the old key so subsequentsaveDisplayPrefs()calls don't carry the orphan forward:The remove only fires once per slice (the next load will already see
keyWand skip theelsebranch entirely), so this is a one-time cleanup per settings file.The next
saveDisplayPrefs()call (or the first one after this load) writes the new layout without the orphan, matching the issue's "save once on the next opportunity" approach.Tiny single-file fix as flagged in the issue.