Conversation
The four-button row in the per-slice DSP panel (Thin / Thick / Edges /
Hide) is collapsed to two:
- **Marker** — cycles Off → 1 px → 3 px on click. Label reflects
the current state ("Marker: Off" / "Marker: 1px" / "Marker: 3px").
Off skips both the center line and the top triangle, leaving only
the passband bracket.
- **Filter Edge** — checkable on/off. Checked = edges shown.
Internally `bool m_markerThin` becomes `int m_markerWidth` (0 / 1 / 3),
the `markerStyleChanged` signal becomes `(int markerWidth, bool
filterEdgesHidden)`, and `SpectrumWidget::SliceOverlay::markerThin`
becomes `markerWidth` with a render-path guard for the off case.
Settings: new `Slice<N>_MarkerWidth` int key. Old `Slice<N>_MarkerThin`
bool key is read once for migration (True → 1, False → 3) and then
the new key takes over.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
ten9876
deleted the
auto/VfoWidget-collapse-marker--edges-buttons-add-Marke
branch
This was referenced Apr 29, 2026
ten9876
added a commit
that referenced
this pull request
Apr 29, 2026
Community-driven release. WAVE Phase 2 visualization (#2124), DAX-aware TCI multi-stream routing for FlexRadio firmware 4.2.18 (#2140), TCXO frequency-offset calibration (#2119), VFO marker tri-state UX (#2141), v4.2.18 discovery beacon parsing (#2138). Bug fixes from the community: r8b heap corruption (#2114, NF0T), serial PTT triple-fix (#2125, chibondking), slice-audio mute on band change (#2128, jensenpat), CWX Live toggle (#2122, jensenpat), connect-radio dialog polish (#2121, jensenpat). Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
ten9876
pushed a commit
that referenced
this pull request
Apr 30, 2026
) Resolves #2143. #2141 migrated per-slice marker-style preferences from `Slice<N>_MarkerThin` (bool) to `Slice<N>_MarkerWidth` (int 0/1/3). `loadDisplayPrefs()` reads the old key only as a fallback when the new key is absent, but never deletes it -- so the orphan accumulates in `~/.config/AetherSDR/AetherSDR.settings` indefinitely. After migrating the value into `m_markerWidth`, remove the old key so subsequent `saveDisplayPrefs()` calls don't carry the orphan forward. The remove only fires once per slice (the next load will already see `keyW` and skip the else branch entirely), so this is a one-time cleanup per setting file. Tiny single-file fix as flagged in the issue. Co-authored-by: Matt Van Horn <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four-button row in the per-slice DSP panel (Thin / Thick / Edges /
Hide) is collapsed to two:
the current state ("Marker: Off" / "Marker: 1px" / "Marker: 3px").
Off skips both the center line and the top triangle, leaving only
the passband bracket.
Internally
bool m_markerThinbecomesint m_markerWidth(0 / 1 / 3),the
markerStyleChangedsignal becomes(int markerWidth, bool filterEdgesHidden), andSpectrumWidget::SliceOverlay::markerThinbecomes
markerWidthwith a render-path guard for the off case.Settings: new
Slice<N>_MarkerWidthint key. OldSlice<N>_MarkerThinbool key is read once for migration (True → 1, False → 3) and then
the new key takes over.
Co-Authored-By: Claude Opus 4.7 (1M context) [email protected]