Parse is_system_model and turf_region from v4.2.18 discovery beacon (#2133)#2138
Merged
Parse is_system_model and turf_region from v4.2.18 discovery beacon (#2133)#2138
Conversation
…2133) Add isSystemModel (bool) and turfRegion (string) fields to RadioInfo, parse them in the discovery packet handler, and surface turfRegion in the connect dialog radio label. Co-Authored-By: Claude Opus 4.6 <[email protected]>
3 tasks
Contributor
Author
There was a problem hiding this comment.
Clean, well-scoped change. A few observations:
Looks good:
- New fields in
RadioInfohave sensible defaults (false/ emptyQString), so existing code that doesn't touch them is unaffected. - Parsing follows the existing
parseDiscoveryPacketpattern exactly — no new allocation, no new error paths. - All three files are squarely within scope for the stated issue.
- No convention issues — no
QSettings, no raw pointers to manage, consistent style with surrounding code.
One minor note on the ConnectionPanel display:
turfRegionis appended to the detail line raw. If the radio sends something liketurf_region=USAthat's fine, but if it ever contains underscores or unexpected formatting (like thestatusfield does), you may want to run it throughnormalizedStatus()-style cleanup. Not blocking — just something to keep in mind if users report odd-looking labels.
No issues found with null safety, resource leaks, or out-of-scope changes. isSystemModel is parsed and stored but not yet displayed in the UI, which is fine — it's available for future use and doesn't add dead code risk since it's just a struct field.
Thanks for the contribution, @aethersdr-agent — straightforward and correct. 👍
ten9876
added a commit
that referenced
this pull request
Apr 29, 2026
Community-driven release. WAVE Phase 2 visualization (#2124), DAX-aware TCI multi-stream routing for FlexRadio firmware 4.2.18 (#2140), TCXO frequency-offset calibration (#2119), VFO marker tri-state UX (#2141), v4.2.18 discovery beacon parsing (#2138). Bug fixes from the community: r8b heap corruption (#2114, NF0T), serial PTT triple-fix (#2125, chibondking), slice-audio mute on band change (#2128, jensenpat), CWX Live toggle (#2122, jensenpat), connect-radio dialog polish (#2121, jensenpat). Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2133
What was changed
Parse is_system_model and turf_region from v4.2.18 discovery beacon (#2133)
Files modified
src/core/RadioDiscovery.cppsrc/core/RadioDiscovery.hsrc/gui/ConnectionPanel.cppGenerated by AetherClaude (automated agent for AetherSDR)