Skip to content

Parse is_system_model and turf_region from v4.2.18 discovery beacon (#2133)#2138

Merged
ten9876 merged 1 commit intomainfrom
aetherclaude/issue-2133
Apr 29, 2026
Merged

Parse is_system_model and turf_region from v4.2.18 discovery beacon (#2133)#2138
ten9876 merged 1 commit intomainfrom
aetherclaude/issue-2133

Conversation

@aethersdr-agent
Copy link
Copy Markdown
Contributor

Summary

Fixes #2133

What was changed

Parse is_system_model and turf_region from v4.2.18 discovery beacon (#2133)

Files modified

  • src/core/RadioDiscovery.cpp
  • src/core/RadioDiscovery.h
  • src/gui/ConnectionPanel.cpp
 src/core/RadioDiscovery.cpp | 2 ++
 src/core/RadioDiscovery.h   | 2 ++
 src/gui/ConnectionPanel.cpp | 3 +++
 3 files changed, 7 insertions(+)

Generated by AetherClaude (automated agent for AetherSDR)

…2133)

Add isSystemModel (bool) and turfRegion (string) fields to RadioInfo,
parse them in the discovery packet handler, and surface turfRegion in
the connect dialog radio label.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Copy link
Copy Markdown
Contributor Author

@aethersdr-agent aethersdr-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-scoped change. A few observations:

Looks good:

  • New fields in RadioInfo have sensible defaults (false / empty QString), so existing code that doesn't touch them is unaffected.
  • Parsing follows the existing parseDiscoveryPacket pattern exactly — no new allocation, no new error paths.
  • All three files are squarely within scope for the stated issue.
  • No convention issues — no QSettings, no raw pointers to manage, consistent style with surrounding code.

One minor note on the ConnectionPanel display:

  • turfRegion is appended to the detail line raw. If the radio sends something like turf_region=USA that's fine, but if it ever contains underscores or unexpected formatting (like the status field does), you may want to run it through normalizedStatus()-style cleanup. Not blocking — just something to keep in mind if users report odd-looking labels.

No issues found with null safety, resource leaks, or out-of-scope changes. isSystemModel is parsed and stored but not yet displayed in the UI, which is fine — it's available for future use and doesn't add dead code risk since it's just a struct field.

Thanks for the contribution, @aethersdr-agent — straightforward and correct. 👍

@ten9876 ten9876 merged commit 0b32734 into main Apr 29, 2026
5 checks passed
@ten9876 ten9876 deleted the aetherclaude/issue-2133 branch April 29, 2026 04:37
ten9876 added a commit that referenced this pull request Apr 29, 2026
Community-driven release.  WAVE Phase 2 visualization (#2124),
DAX-aware TCI multi-stream routing for FlexRadio firmware 4.2.18
(#2140), TCXO frequency-offset calibration (#2119), VFO marker
tri-state UX (#2141), v4.2.18 discovery beacon parsing (#2138).
Bug fixes from the community: r8b heap corruption (#2114, NF0T),
serial PTT triple-fix (#2125, chibondking), slice-audio mute on
band change (#2128, jensenpat), CWX Live toggle (#2122, jensenpat),
connect-radio dialog polish (#2121, jensenpat).

Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Protocol v4.2.18: discovery beacon adds is_system_model + turf_region

1 participant