Add Clear action to CW decode window context menu (#2115)#2116
Merged
aethersdr-agent[bot] merged 1 commit intomainfrom Apr 28, 2026
Merged
Add Clear action to CW decode window context menu (#2115)#2116aethersdr-agent[bot] merged 1 commit intomainfrom
aethersdr-agent[bot] merged 1 commit intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Closed
2 tasks
![aethersdr-agent[bot]](https://avatars.githubusercontent.com/in/3286087?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Looks good — small, focused change that does exactly what the issue asks for.
What I checked:
clearCwText()already exists (PanadapterApplet.cpp:372) and is wired to the existing clear button, so reusing it here is correct.QMenuinclude is needed and placed in alphabetical order — fine.createStandardContextMenu()returns a heap-allocatedQMenu*; the explicitdelete menuafterexec()is correct (no leak). An alternative would bemenu->setAttribute(Qt::WA_DeleteOnClose), but the current approach is equally valid and matches Qt examples.- Scope is exactly one file, matching the PR description.
- No null-pointer risk:
m_cwTextis initialized unconditionally earlier in the constructor (line 279), so the lambda capture ofthisand dereference ofm_cwTextare safe.
No issues found. Thanks for the contribution, @aethersdr-agent!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2115
What was changed
Add Clear action to CW decode window context menu (#2115)
Files modified
src/gui/PanadapterApplet.cppGenerated by AetherClaude (automated agent for AetherSDR)