Fix rigctld short-form split commands mapped to wrong get/set direction (#2108)#2111
Merged
Fix rigctld short-form split commands mapped to wrong get/set direction (#2108)#2111
Conversation
…on (#2108) The short-form commands S, I, X were incorrectly calling get functions instead of set functions, and their lowercase counterparts s, i, x (get operations) were missing entirely. This fixes the mapping to match the rigctld protocol specification. Co-Authored-By: Claude Opus 4.6 <[email protected]>
2 tasks
![aethersdr-agent[bot]](https://avatars.githubusercontent.com/in/3286087?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Reviewed the diff against main and the rigctld short-form protocol conventions.
Correctness: The fix is correct. The existing code on main maps uppercase S, I, X to the getter functions, which is backwards — the rigctld convention (visible in the same switch for f/F, m/M, t/T, l/L) is lowercase = get, uppercase = set. The PR:
- Reassigns
S,I,Xto the correctcmdSet*functions - Adds the missing lowercase
s,i,xentries forcmdGet*
This matches the hamlib rigctld protocol spec. No bugs, no scope creep, no resource issues — just a clean mapping fix.
Scope: Single file (RigctlProtocol.cpp), tightly scoped to the reported issue. No unrelated changes.
Looks good. Thanks for the fix, @aethersdr-agent!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2108
What was changed
Fix rigctld short-form split commands mapped to wrong get/set direction (#2108)
Files modified
src/core/RigctlProtocol.cppGenerated by AetherClaude (automated agent for AetherSDR)