Fix USB mic level gauge not showing on connect when mic source is PC (#2085)#2086
Fix USB mic level gauge not showing on connect when mic source is PC (#2085)#2086
Conversation
…2085) The met_in_rx gate in updateMeters() was suppressing client-side PC mic metering during RX. PC mic metering is driven by QAudioSource on the client, independent of the radio's met_in_rx state, so skip the gate when mic source is "PC". Co-Authored-By: Claude Opus 4.6 <[email protected]>
![aethersdr-agent[bot]](https://avatars.githubusercontent.com/in/3286087?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. Small, focused fix that correctly addresses the bug.
What the change does: When mic source is "PC", the client generates its own metering (since the radio always returns mic_level=0 for PC sources — see syncPhoneFromModel() at line 654). The old suppression logic blanked the gauge whenever met_in_rx was off and not transmitting, which inadvertently hid the PC mic level on connect. Adding the micSelection() != "PC" exception is the right fix — PC metering is client-authoritative and shouldn't be gated by the radio's met_in_rx flag.
Code quality: Uses QStringLiteral for the comparison, only touches the file in scope, no new risks introduced. The condition reads clearly with the && on its own line.
No issues found. Thanks for the fix, @aethersdr-agent!
1 participant
Summary
Fixes #2085
What was changed
Fix USB mic level gauge not showing on connect when mic source is PC (#2085)
Files modified
src/gui/PhoneCwApplet.cppGenerated by AetherClaude (automated agent for AetherSDR)