POC: Implement basic endpoint for fetching workflow executions#6
Merged
Conversation
…ontainerized Temporal This is a very naive implementation of an endpoint that can talk to the containerized version of Temporal to fetch a list of workflow executions. The types need work and there are clearly more query parameters that we'll need to support. There are edge cases left unhandled. But, it's a quick proof of concept that will allow us to work against the fixtures in the `samples-go` repository as we build out some of the pages. To-do: - Make this work with single-binary, web-v2 server. - Figure out how we're going to bundle this with the single binary (we may choose not to and only use these endpoints in the cloud version). - Add support for the rest of the query parameters currently supported. - Add better handling. - Refine types. - Add support for respecting next page tokens. - (Probably much more)
Contributor
|
approving with a plan to eventually build the typescript types from API |
feedmeapples
approved these changes
Jul 9, 2021
feedmeapples
reviewed
Jul 9, 2021
| "$lib/*": ["src/lib/*"], | ||
| "$components/*": ["./src/components/*"], | ||
| "$utilities/*": ["./src/utilities/*"] | ||
| "$components/*": ["src/components/*"], |
Contributor
There was a problem hiding this comment.
afaik eventually we want to have src/<feature-name>/components structuring?
Contributor
Author
There was a problem hiding this comment.
SvelteKit mostly does the feature-based folder structure with routes, src/components is for common components that are used throughout the application.
6 tasks
tegan-temporal
added a commit
that referenced
this pull request
Jul 8, 2026
- activity-options-update-drawer: default backoffCoefficient to 2 (server default) instead of 0 — Temporal rejects < 1, and the full field mask always submits it. (finding 2) - getFirstWholeNumberUnit: add overloads so passing a defaultUnit returns a non-undefined label; narrow initialTimeoutUnit to DefaultUnits and drop 4 now-dead `?? 'second(s)'` fallbacks. (finding 4) - dangerfile: match changed files by normalized path equality instead of fragile bidirectional substring (missed regressions / false-blocked suffix collisions). (finding 5) - timeline-graph-row: guard divide-by-zero so an undefined workflowDistance yields 0, not Infinity, as an SVG coordinate. (finding 7) - rename MostRecentWOrkflowVersionStamp -> MostRecentWorkflowVersionStamp typo (now load-bearing imported surface). (finding 9) Deferred: #3 (requestFromAPI -> Promise<T|undefined> is a 128-call-site refactor, its own PR), #6 (documented zod input/output boundary), #8 (pre-existing on main, not this change).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC: Implement basic endpoint for fetching workflow executions from containerized Temporal
This is a very naive implementation of an endpoint that can talk to the containerized version of Temporal to fetch a list of workflow executions.
The types need work and there are clearly more query parameters that we'll need to support. There are edge cases left unhandled. But, it's a quick proof of concept that will allow us to work against the fixtures in the
samples-gorepository as we build out some of the pages.To-do: