Skip to content

Add Cypress to CI/CD#5

Merged
stevekinney merged 8 commits into
mainfrom
cypress-ci
Jul 8, 2021
Merged

Add Cypress to CI/CD#5
stevekinney merged 8 commits into
mainfrom
cypress-ci

Conversation

@stevekinney

Copy link
Copy Markdown
Contributor

What was changed

Added Cypress tests to the CI/CD pipeline

@stevekinney stevekinney changed the title Cypress ci Add Cypress to CI/CD Jul 8, 2021
@softwarecurator
softwarecurator self-requested a review July 8, 2021 22:40

@softwarecurator softwarecurator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@stevekinney
stevekinney merged commit 038dd98 into main Jul 8, 2021
@stevekinney
stevekinney deleted the cypress-ci branch July 8, 2021 22:43
hferentschik pushed a commit to hferentschik/temporal-ui that referenced this pull request Aug 13, 2025
At least one less SSO click per day. Customer ask.

When a stale ID token is found, transparently triggers the Vault OIDC flow rather than requiring a user click through (shown below).

<img width="1563" alt="Screenshot 2024-06-27 at 4 31 04 PM" src="https://github.com/DataDog/temporalio-ui/assets/22668869/1d4fb843-4fbd-41c2-9205-efff3ca39871">

Following the standard procedure (e.g. https://github.com/DataDog/dd-source/pull/104445).

## Test Plan

### Self

```
// from the console, set a stale token
localStorage.setItem("AuthUser", '{"idToken":"eyJhbGciOiJSUzI1NiIsImtpZCI6IjY3YWEyNmIxLTMzODQtZGEzMi04M2E4LWIyOGMwMDU4MDI3YyJ9.eyJhdWQiOiAiYXRsYXMtc3RhZ2luZyIsICJkYXRhY2VudGVyIjogInVzMS5kZGJ1aWxkLmlvIiwgImVtYWlsIjogImJyZW5kYW4uZ2Vycml0eUBkYXRhZG9naHEuY29tIiwgImV4cCI6IDEwMCwgImdyb3VwcyI6IFtdfQo.aGE8Z2oH8NKq9X_3ivuaXsc2J_WSh71tT4_HQZlEHDPBP87uX6lYVITjLTCQSYpA5sABqmFCLHpL6VAMC9B53cFk4j5D9Gxg7pFfnVbPfafSg4iuaoB4AzAd_Gyyzf2cEzxqWcl1oaxTti69EcsjE-BronbnY74k8sGMsegKjqormsHg4QsuzOOY8q2ZPtU1pYuslCY0QeBbtfBb9vInsSocopREptl20q37e3QRGRV0031mn2ZR4qW0zM7YD1IstbUDWJioDAl2cpJL-VoUkqrRCCfUbNFBaKcQHurJMRCopRcK999499XSNR423VcbAFc9ezFim5al6uGBOHTrDw=","name":"brendan.gerrity","email":"[email protected]"}');
```

Refresh and watch the console to see the redirect. Shouldn't see the login page.

Tested both with and without proxy in gizmo.

### Non-Domains Authorized

```
kubectl port-forward deployments/temporal-ui-server 8080:8080 --namespace atlas-dev --context gizmo.us1.staging.dog

# hit http://localhost:8080/
# screenshot

# chrome dev console
localStorage.setItem("AuthUser", '{"idToken":"eyJhbGciOiJSUzI1NiIsImtpZCI6IjY3YWEyNmIxLTMzODQtZGEzMi04M2E4LWIyOGMwMDU4MDI3YyJ9.eyJhdWQiOiAiYXRsYXMtc3RhZ2luZyIsICJkYXRhY2VudGVyIjogInVzMS5kZGJ1aWxkLmlvIiwgImVtYWlsIjogImJyZW5kYW4uZ2Vycml0eUBkYXRhZG9naHEuY29tIiwgImV4cCI6IDEwMCwgImdyb3VwcyI6IFtdfQo.aGE8Z2oH8NKq9X_3ivuaXsc2J_WSh71tT4_HQZlEHDPBP87uX6lYVITjLTCQSYpA5sABqmFCLHpL6VAMC9B53cFk4j5D9Gxg7pFfnVbPfafSg4iuaoB4AzAd_Gyyzf2cEzxqWcl1oaxTti69EcsjE-BronbnY74k8sGMsegKjqormsHg4QsuzOOY8q2ZPtU1pYuslCY0QeBbtfBb9vInsSocopREptl20q37e3QRGRV0031mn2ZR4qW0zM7YD1IstbUDWJioDAl2cpJL-VoUkqrRCCfUbNFBaKcQHurJMRCopRcK999499XSNR423VcbAFc9ezFim5al6uGBOHTrDw=","name":"brendan.gerrity","email":"[email protected]"}');

# again, hit http://localhost:8080/
# screenshot

# chrome dev console
localStorage.getItem("AuthUser")
# copy output
```

## Risks

There may be some security conventions or best practices that users should click or take an active step.
hferentschik pushed a commit to hferentschik/temporal-ui that referenced this pull request Aug 13, 2025
hferentschik pushed a commit to hferentschik/temporal-ui that referenced this pull request Aug 13, 2025
Revert "[WFENG-2551] go straight to vault for SSO (temporalio#5)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants